This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013年03月31日 19:43 by rpetrov, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 0004-MINGW-configure-MACHDEP-and-platform-for-build.patch | rpetrov, 2013年03月31日 19:43 | review | ||
| MINGW-MACHDEP.v2.patch | martin.panter, 2016年03月12日 02:30 | review | ||
| Messages (3) | |||
|---|---|---|---|
| msg185650 - (view) | Author: Roumen Petrov (rpetrov) * | Date: 2013年03月31日 19:43 | |
split of issue3871 |
|||
| msg261600 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2016年03月11日 21:00 | |
There are some spelling errors in the comments. It would also be good to keep the indentation, quoting, layout etc similar to the surrounding code. Regarding the comments, what is the significance of "runtime platform" vs MACHDEP? Also, what is the significance of sys.platform() when setting _PYTHON_HOST_PLATFORM? Why did you use different types of comments? (# vs dnl) I do not understand the comment "build must not depend from posix-compatible environment". Is this just explaining that we are setting ac_sys_system (uname -s) to a dummy generic value that will not trigger any special cases. Should we also set ac_sys_release to an empty string, like the cross-compiling case later on? What’s the go with the two competing "mingw*)" cases when determining _PYTHON_HOST_PLATFORM? What is the situation where $host matches *-*-mingw*, but $host_os does not match mingw*? |
|||
| msg261632 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2016年03月12日 02:30 | |
Here is a modified patch fixing a couple of the spelling & style problems. I moved the comment introducing the ac_sys_ variables up to before the code that sets them. I rearranged the logic for _PYTHON_HOST_PLATFORM so it is clear that $host_os overrides $host, and I combined the cygwin and mingw cases. I suspect the configure.ac logic could be simplified more. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:43 | admin | set | github: 61792 |
| 2021年10月20日 12:42:30 | iritkatriel | set | status: open -> closed resolution: duplicate stage: patch review -> resolved |
| 2016年03月12日 02:30:08 | martin.panter | set | files:
+ MINGW-MACHDEP.v2.patch messages: + msg261632 |
| 2016年03月11日 21:04:42 | martin.panter | link | issue17605 dependencies |
| 2016年03月11日 21:00:55 | martin.panter | set | nosy:
+ martin.panter messages: + msg261600 stage: patch review |
| 2013年03月31日 19:43:30 | rpetrov | create | |