This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2013年01月11日 08:56 by chris.jerdonek, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg179654 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2013年01月11日 08:56 | |
This issue is to mention in the devguide how to create diffs with the changeset number when --git is configured on. Perhaps this can be done via a FAQ like: "How can I get Rietveld to work with a 2.7 patch?" Background: Currently, the devguide recommends configuring Mercurial to use --git when making diffs. However, this causes the changeset ID to be left off of patch files and, for example, prevents Rietveld from working with patches to non-default branches. See also this thread: http://mail.python.org/pipermail/python-dev/2011-March/108765.html This issue describes a couple work-arounds: http://bz.selenic.com/show_bug.cgi?id=3761 |
|||
| msg183085 - (view) | Author: Ned Deily (ned.deily) * (Python committer) | Date: 2013年02月26日 20:53 | |
However this is resolved, the information in the devguide should be consistent. AFAICT, the recommendation to use hg "git" format is currently only mentioned in the Committing section (http://docs.python.org/devguide/committing.html#minimal-configuration) but not elsewhere, in particular, not http://docs.python.org/devguide/patch.html. (This was brought up in Issue10572.) Perhaps both sections could reference a FAQ entry which includes the Rietveld caveats. |
|||
| msg183127 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2013年02月27日 09:59 | |
> AFAICT, the recommendation to use hg "git" format is currently only mentioned in the Committing section (http://docs.python.org/devguide/committing.html#minimal-configuration) but not elsewhere, in particular, not http://docs.python.org/devguide/patch.html. Good observation. Personally, I think it makes sense to keep Mercurial information for both committers and non-committers (like configuring to use the "git" format) outside of the Mercurial section specific to committers. This can be in a general Mercurial section before the section specific to committers, or else spread throughout (e.g. in the FAQ). |
|||
| msg184144 - (view) | Author: Ezio Melotti (ezio.melotti) * (Python committer) | Date: 2013年03月14日 08:08 | |
> This can be in a general Mercurial section before the section specific > to committers, or else spread throughout (e.g. in the FAQ). FWIW I'm leaning towards making the committing.rst page for committers only, and move general instructions for non-committers elsewhere. For this issue I think it might be OK to either add a FAQ about Rietveld that also mentions the git format, or possibly include it in a new "Rietveld" section somewhere in the tracker docs (see #13963). |
|||
| msg271021 - (view) | Author: Brett Cannon (brett.cannon) * (Python committer) | Date: 2016年07月22日 19:53 | |
With the pending migration to git, this probably isn't worth the effort. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:40 | admin | set | github: 61135 |
| 2016年07月22日 19:53:26 | brett.cannon | set | status: open -> closed nosy: + brett.cannon messages: + msg271021 resolution: out of date |
| 2015年04月18日 22:52:17 | willingc | set | assignee: willingc nosy: + willingc |
| 2013年03月14日 08:08:34 | ezio.melotti | set | type: enhancement messages: + msg184144 stage: needs patch |
| 2013年02月27日 09:59:01 | chris.jerdonek | set | messages: + msg183127 |
| 2013年02月26日 20:53:34 | ned.deily | set | nosy:
+ ned.deily messages: + msg183085 |
| 2013年01月11日 21:00:25 | tshepang | set | nosy:
+ tshepang |
| 2013年01月11日 08:56:51 | chris.jerdonek | create | |