This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2006年05月18日 13:22 by sidnei, last changed 2022年04月11日 14:56 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| progresshook.diff | nelchael, 2008年12月07日 21:10 | Patch adding progresshook | review | |
| test_urllib.patch | zanella, 2011年04月24日 22:45 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg60914 - (view) | Author: Sidnei da Silva (sidnei) | Date: 2006年05月18日 13:22 | |
Seems like the 'reporthook', when provided to the 'retrieve' function of urllib will be called with (blocknumber, blocksize, totalsize). However, the call to read() might return *less* than 'blocksize' bytes (I believe), so it should imho be called with len(block) as the second argument instead. Or maybe add a fourth argument 'readbytes'. |
|||
| msg77257 - (view) | Author: Krzysztof Pawlik (nelchael) | Date: 2008年12月07日 21:10 | |
Attached patch adds new argument: progresshook - it will be passed two arguments: count of downloaded bytes and total file size (or -1 if it's not available). Introducing new argument instead of modifying reporthook maintains backwards compatibility, also allows removal of reporthook at one point in the future. This patch is against r30 SVN tag. |
|||
| msg81786 - (view) | Author: Daniel Diniz (ajaksu2) * (Python triager) | Date: 2009年02月12日 17:44 | |
Patch has docs, tests needed. |
|||
| msg134357 - (view) | Author: Rafael Zanella (zanella) | Date: 2011年04月24日 22:45 | |
Simple (lazy) test case added. It just replicates one test case of reporthook to work with progresshook. The testcases assume the hard-coded value of blocksize on urllib, maybe it should become a public property. Also commented on diff: http://bugs.python.org/review/1490929/show |
|||
| msg174870 - (view) | Author: Akira Li (akira) * | Date: 2012年11月05日 07:17 | |
Related issue 16409 |
|||
| msg379618 - (view) | Author: Irit Katriel (iritkatriel) * (Python committer) | Date: 2020年10月25日 23:21 | |
The code in urllib is different now but I see that a test very similar to the one in the patch exists, so was this fixed? https://github.com/python/cpython/blob/e68c67805e6a4c4ec80bea64be0e8373cc02d322/Lib/test/test_urllib.py#L813 |
|||
| msg379649 - (view) | Author: Senthil Kumaran (orsenthil) * (Python committer) | Date: 2020年10月26日 07:58 | |
> so was this fixed? Irit, not really. This is adding another hook called "progress hook" in addition to the "report hook". We need to evaluate if this is really required. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:17 | admin | set | github: 43374 |
| 2020年10月26日 08:00:19 | iritkatriel | set | stage: test needed -> versions: + Python 3.8, Python 3.9, Python 3.10, - Python 3.2 |
| 2020年10月26日 07:58:27 | orsenthil | set | status: pending -> open messages: + msg379649 |
| 2020年10月25日 23:21:10 | iritkatriel | set | status: open -> pending nosy: + iritkatriel messages: + msg379618 |
| 2012年11月05日 07:17:25 | akira | set | nosy:
+ akira messages: + msg174870 |
| 2011年04月24日 22:45:45 | zanella | set | files:
+ test_urllib.patch nosy: + zanella messages: + msg134357 |
| 2010年08月24日 03:18:26 | orsenthil | set | assignee: orsenthil |
| 2010年08月22日 10:20:13 | BreamoreBoy | set | versions: + Python 3.2, - Python 2.7 |
| 2009年04月22日 18:48:49 | ajaksu2 | set | keywords: + easy |
| 2009年02月12日 17:44:18 | ajaksu2 | set | nosy:
+ ajaksu2, orsenthil stage: test needed messages: + msg81786 versions: + Python 2.7 |
| 2008年12月07日 21:10:23 | nelchael | set | files:
+ progresshook.diff keywords: + patch messages: + msg77257 nosy: + nelchael |
| 2006年05月18日 13:22:13 | sidnei | create | |