This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年12月09日 15:54 by Keto, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| httperror-geturl-fix-2.patch | Keto, 2011年12月09日 15:54 | HTTPError patch for 2.7 | review | |
| httperror-geturl-fix-3.patch | Keto, 2011年12月09日 16:18 | HTTPError patch for 3.3 | review | |
| Messages (2) | |||
|---|---|---|---|
| msg149106 - (view) | Author: Pami Ketolainen (Keto) | Date: 2011年12月09日 15:54 | |
In case of authentication error, HTTPError gets initialized without file object and constructor of addinfourl is not called. This means that url attribute is not set and geturl() (inherited from addinfourl) raises AttributeError. geturl() is not documented as part of HTTPError interface, so I'm not sure if it is correct to expect it to work. And of course this can be worked around by using the HTTPError.filename which always contains the url passed to constructor. How ever, I have made a simple patch to fix the missing attribute. There is also Issue5286 with a patch, which makes the http_error_auth_reqed pass the fp to HTTPError making it a file-like object as stated in the documentation. So that would probably be the correct solution. IMHO it's a bit bad design, when objects interface changes depending on how it was initialized. |
|||
| msg149107 - (view) | Author: Pami Ketolainen (Keto) | Date: 2011年12月09日 16:18 | |
Patch adapted to 3.3 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:24 | admin | set | github: 57776 |
| 2015年04月26日 16:41:44 | demian.brecht | set | nosy:
+ demian.brecht |
| 2015年04月25日 12:08:14 | berker.peksag | set | nosy:
+ berker.peksag stage: patch review versions: + Python 3.4, Python 3.5, - Python 3.2, Python 3.3 |
| 2011年12月10日 16:42:11 | eric.araujo | set | nosy:
+ ezio.melotti, eric.araujo versions: - Python 2.6, Python 3.1, Python 3.4 |
| 2011年12月09日 16:18:21 | Keto | set | files:
+ httperror-geturl-fix-3.patch messages: + msg149107 |
| 2011年12月09日 15:54:42 | Keto | create | |