This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011年05月10日 19:37 by jcon, last changed 2022年04月11日 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue12053-pyio.patch | jcon, 2011年05月28日 19:17 | _pyio prefetch() implementation | review | |
| issue12053-tests.patch | jcon, 2011年05月28日 19:17 | test cases | review | |
| prefetch.patch | jcon, 2011年10月04日 01:14 | C impl + pyio + tests | review | |
| Messages (6) | |||
|---|---|---|---|
| msg135731 - (view) | Author: John O'Connor (jcon) | Date: 2011年05月10日 19:37 | |
A prefetch() method for Buffered IO may greatly assist 3rd party buffering among other gains. If nothing else, it is worth experimenting with. Discussion on the topic is here: http://mail.python.org/pipermail/python-ideas/2010-September/008180.html A summary of the method proposed (by Antoine Pitrou): prefetch(self, buffer, skip, minread) Skip `skip` bytes from the stream. Then, try to read at least `minread` bytes and write them into `buffer`. The file pointer is advanced by at most `skip + minread`, or less if the end of file was reached. The total number of bytes written in `buffer` is returned, which can be more than `minread` if additional bytes could be prefetched (but, of course, cannot be more than `len(buffer)`). Arguments: - `buffer`: a writable buffer (e.g. bytearray) - `skip`: number of bytes to skip (must be >= 0) - `minread`: number of bytes to read (must be >= 0 and <= len(buffer)) |
|||
| msg137143 - (view) | Author: John O'Connor (jcon) | Date: 2011年05月28日 19:17 | |
I started a draft in python. I am attaching the _pyio version along with tests. I will continue work on the C implementation and eventually documentation if this is well received. It seems straightforward, I am interested to see what you guys think.
Also, there are now 2 places which use hasattr(self, "peek"). I was wondering if it would make sense to add peek() to BufferedIOBase and raise UnsupportedOperation or return b"".
Some benchmarks..
$ ./python -m timeit -s "from _pyio import open;f = open('LICENSE', 'rb'); b=bytearray(128)" 'while f.prefetch(b, 4, 4): pass'
_pyio.BufferedIOBase.prefetch:
100000 loops, best of 3: 10.6 usec per loop
_pyio.BufferedReader.prefetch:
100000 loops, best of 3: 6 usec per loop
$ ./python -m timeit -s "from _pyio import open;f = open('LICENSE', 'rb');b=bytearray(4);" 'while f.read(4): f.readinto(b)'
100000 loops, best of 3: 5.07 usec per loop
|
|||
| msg138118 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2011年06月10日 17:17 | |
> I started a draft in python. I am attaching the _pyio version along > with tests. I will continue work on the C implementation and > eventually documentation if this is well received. It seems > straightforward, I am interested to see what you guys think. Thank you. I think performance measurements are prematurate until we have an optimized C implementation anyway. I think ultimately we also want a default implementation of read(), peek() and read1() which uses prefetch(), so that BufferedReader implementations only have to implement prefetch(). (care must be taken to avoid infinite loops) That said, I think the python-dev mailing-list needs to be convinced of the usefulness of prefetch() (if it was only me, there wouldn't be any problem :-)). Perhaps you want to run another discussion there. |
|||
| msg144848 - (view) | Author: John O'Connor (jcon) | Date: 2011年10月04日 01:14 | |
Here is an update with the C implementation. I think a working prototype will be helpful before another round on python-dev. I'm not sure how to handle unseekable, non-blocking streams where the read returns before `skip` bytes are exhausted. If prefetch() returns 0, then the caller would then have to use tell() to ensure subsequent reads are sane. In other words it seems prefetch() will leave the stream in an unpredictable state. Antoine, what are your thoughts? |
|||
| msg240247 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2015年04月08日 03:34 | |
Sounds like this might be more appropriate for the BufferedReader and related classes, and less so for the writer and abstract base class. The proposed API seems strange to me. Is there an illustration of how it might be used? I suspect it wouldn’t be all that useful, and could more or less be implemented with the existing methods: def prefetch(buffered_reader, buffer, skip, minread): buffered_reader.read(skip) consumed = buffered_reader.readinto(buffer[:minread]) if consumed < minread: return consumed spare = len(buffer) - consumed extra = buffered_reader.peek(spare)[:spare] total = consumed + len(extra) buffer[consumed:total] = extra return total Maybe it would be better to focus on clarifying or redefining the existing peek() method (Issue 5811), rather than making a brand new do-everything method which only seems to do what the other methods already do. |
|||
| msg240672 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2015年04月13日 17:24 | |
> The proposed API seems strange to me. Is there an illustration of how > it might be used? I suspect it wouldn’t be all that useful, and could > more or less be implemented with the existing methods: True, but having it a Buffered method would allow it to optimize buffer usage and avoid some memory copies (the first read() call and the peek() call, for example). In any case, Guido was rather against this proposal, so I'm not sure there's much sense in keeping discussing it. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:17 | admin | set | github: 56262 |
| 2015年04月13日 17:24:06 | pitrou | set | messages: + msg240672 |
| 2015年04月08日 03:34:20 | martin.panter | set | messages: + msg240247 |
| 2014年12月21日 03:13:29 | martin.panter | set | nosy:
+ martin.panter |
| 2013年09月19日 15:26:22 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka |
| 2011年10月04日 01:14:46 | jcon | set | files:
+ prefetch.patch messages: + msg144848 |
| 2011年06月10日 17:17:58 | pitrou | set | messages: + msg138118 |
| 2011年05月28日 19:17:32 | jcon | set | files: + issue12053-tests.patch |
| 2011年05月28日 19:17:13 | jcon | set | files:
+ issue12053-pyio.patch keywords: + patch messages: + msg137143 |
| 2011年05月10日 19:50:41 | nadeem.vawda | set | nosy:
+ nadeem.vawda |
| 2011年05月10日 19:37:24 | jcon | create | |