homepage

... and that closes the original file, too!
(I've also opened #11700 due to the mailbox.py
side of this.)
static PyObject *
textiowrapper_close(textio *self, PyObject *args)
 return PyObject_CallMethod(self->buffer, "close", NULL);
>>> mb = mailbox.Maildir('sdaoden', create=False)
>>> mbf = mb.get_file(mb.keys()[0])
>>> msg = email.parser.BytesParser().parse(mbf, headersonly=True)
>>> mbf.close()
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/Users/steffen/usr/opt/py3k/lib/python3.3/mailbox.py", line 1922, in close
 if hasattr(self._file, 'close'):
AttributeError: '_ProxyFile' object has no attribute '_file'

This patch fixes the problem.
It was introduced in e727cf35.
David Murray, i've looked into test_email.py to add tests
for this, and i found TestIdempotent().
What i would do is try to split that thing up so that it covers
str() as well as bytes(), rewriting ._msgobj() to use a xy
parser instance so that the file-argument-is-not-closed test
could be embedded in there as a side-effect.
This is however your area, so please let me know if i may
touch this or if you have local modifications to this one
which will make my snail-slow work on it pointless.
Thanks.

For easy reference, here's a hash for that changeset that roundup will turn into a link: e727cf354720.
TestIdempotent is already run for both the bytes and str cases (they are widely separated in the test file...I'll fix that at some point).

On Wed, Apr 13, 2011 at 01:07:28PM +0000, R. David Murray wrote:
> TestIdempotent is already run for both the bytes and str cases
(*^.^*)
Ouch. Searching is only for the experienced.

So i'll changed the existing message_from_(binary_)?file() tests
to also test the file closing.

Right, and that is considered to be a non-issue due to
that close() is allowed multiple times without causing harm.