This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2007年08月28日 22:33 by amaury.forgeotdarc, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| getargs.diff | amaury.forgeotdarc, 2007年08月28日 22:33 | |||
| subprocess.diff | amaury.forgeotdarc, 2007年08月28日 22:34 | |||
| stdout.diff | amaury.forgeotdarc, 2007年08月28日 22:34 | |||
| Messages (4) | |||
|---|---|---|---|
| msg55384 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) | Date: 2007年08月28日 22:33 | |
I join three patches for py3k on Windows: 1/ getargs.diff adds the 'Z' and 'Z#' format specifiers for PyArg_ParseTuple. They mimic z and z# for unicode strings, by accepting a Unicode or None (in which case the Py_UNICODE* pointer is set to NULL). With doc and tests. 2/ subprocess.diff converts file PC/_subprocess.c to unicode. We use the Unicode version of the win32 api (and Z conversion from previous patch) 3/ stdout.diff: sys.stdout must not convert the line endings, Windows already does it. Without this patch, when redirecting the output of python, the file contains \r\r\n for each line. (test_subprocess did catch this) |
|||
| msg55385 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) | Date: 2007年08月28日 22:34 | |
Did I say that test_subprocess now passes on windows? |
|||
| msg55429 - (view) | Author: Guido van Rossum (gvanrossum) * (Python committer) | Date: 2007年08月29日 18:39 | |
Committed revision 57669. I have no way to test this so you'll have to watch the buildbot. However, I didn't include the patch to _fileio.c that prevents closing fds 0, 1, 2; I think that's the wrong thing to do and if it causes problems it needs to be addressed in a different way. |
|||
| msg57293 - (view) | Author: Christian Heimes (christian.heimes) * (Python committer) | Date: 2007年11月09日 01:36 | |
The patch to _fileio was implemented in a different way and applied to the py3k branch a while ago. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:26 | admin | set | github: 45388 |
| 2007年11月09日 01:36:47 | christian.heimes | set | status: open -> closed nosy: + christian.heimes resolution: accepted -> fixed messages: + msg57293 |
| 2007年09月17日 07:38:01 | jafo | set | priority: low |
| 2007年09月02日 20:09:55 | loewis | set | keywords: + patch |
| 2007年08月29日 18:39:08 | gvanrossum | set | resolution: accepted messages: + msg55429 nosy: + gvanrossum |
| 2007年08月28日 22:34:52 | amaury.forgeotdarc | set | files: + stdout.diff |
| 2007年08月28日 22:34:11 | amaury.forgeotdarc | set | files:
+ subprocess.diff messages: + msg55385 |
| 2007年08月28日 22:33:09 | amaury.forgeotdarc | create | |