homepage

Please see attached.

Thanks for the patch, I’ll review it and commit it soon.

The patch shouldn't use context managers, as distutils claims to support 2.3. #10290 contains a similar patch which doesn't use 'with'. (Sorry to duplicate efforts here, forgot to search...)

I don't see your patch on the other bug, so I've updated mine not to use with.

Is it really true that 3.x's distutils is source compatible with 2.3?
For 3.x I'd like to see the with statement used.

Fixed in the py3k branch in r86223, r86224 and r86226. Thanks for the report and starting patch.
Eric: This compatibility policy was instated because a newer version of distutils may be used/is often used to install distributions for older Pythons. In the 2.x line, this was enforced. I checked the current py3k code with the oldest version I have, 2.4, and it’s not entirely compatible. Python 3.x is developed as a clean break from 2.x (no versionchanged directives in docs, etc.), so what’s the status of the distutils compatibility policy? I think that the reasons are still valid, so keeping 2.x source compat in py3k is a nice thing to do for our users. Even if we’re working on distutils2 (which will have releases for 2.4-3.2), distutils is still widely used and we expect a long transition period.
I can bring this up on python-dev if you think it’s needed.

(Not closing yet: Some calls of os.popen and subprocess.Popen are still to be fixed, and then there’s the backport.)

[Pp]open objects closed in r86234.
All fixes ported to 3.1 in r86237, 2.7 in r86238. Cheers!

The tests don’t pass on a Windows buildbot (thanks Antoine): I was mistaken about subprocess.Popen, it has no close method like os.popen objects. Attached patch should fix it, can someone kindly review and/or test it?

Committed to py3k in r86274, after "LGTM" from Brian on IRC. Will backport if buildbots don’t scream at me.

Thanks for the patch. r86276 

Ported to 3.1 and 2.7 in r86433 and r86434.

No file object was created for stdin, so my patch was buggy. Fixed in r86438, r86439, r86440. Thanks to Antoine and Brian.

These constructs don’t generate warnings at present but should IMO use the with statement too:
./distutils/command/upload.py:128: open(filename+".asc").read())
./distutils/command/bdist_rpm.py:514: spec_file.extend(open(val, 'r').read().split('\n'))
./distutils/command/bdist_wininst.py:248: bitmapdata = open(bitmap, "rb").read()
./distutils/command/bdist_wininst.py:288: file.write(open(arcname, "rb").read())
./distutils/command/bdist_msi.py:399: f.write(open(self.pre_install_script).read())

New changeset 85fefd41ef5d by Éric Araujo in branch '3.2':
Fix double use of f.close().
http://hg.python.org/cpython/rev/85fefd41ef5d 

New changeset c02c78d93a2e by Éric Araujo in branch '2.7':
Fix double use of f.close().
http://hg.python.org/cpython/rev/c02c78d93a2e