Index: Objects/unicodeobject.c =================================================================== --- Objects/unicodeobject.c (revision 46758) +++ Objects/unicodeobject.c (working copy) @@ -4491,11 +4491,11 @@ /* Make sure we have enough space for the separator and the item. */ itemlen = PyUnicode_GET_SIZE(item); new_res_used = res_used + itemlen; - if (new_res_used <= 0) + if (new_res_used < 0) goto Overflow; if (i < seqlen - 1) { new_res_used += seplen; - if (new_res_used <= 0) + if (new_res_used < 0) goto Overflow; } if (new_res_used> res_alloc) { Index: Lib/test/string_tests.py =================================================================== --- Lib/test/string_tests.py (revision 46758) +++ Lib/test/string_tests.py (working copy) @@ -908,6 +908,8 @@ # test.test_string.StringTest.test_join) self.checkequal('a b c d', ' ', 'join', ['a', 'b', 'c', 'd']) self.checkequal('abcd', '', 'join', ('a', 'b', 'c', 'd')) + self.checkequal('bd', '', 'join', ('', 'b', '', 'd')) + self.checkequal('ac', '', 'join', ('a', '', 'c', '')) self.checkequal('w x y z', ' ', 'join', Sequence()) self.checkequal('abc', 'a', 'join', ('abc',)) self.checkequal('z', 'a', 'join', UserList(['z']))