ecryptfs-manager runs into infinite loop if user doesn't install openssl and selects the third option
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| eCryptfs |
Fix Committed
|
Undecided
|
Unassigned | ||
Bug Description
Reproduce case:
1) User doesn't install openssl.
2) Run ecryptfs-manager and make selection 3.
It goes in the infinite loop...which means whatever selection you choose cannot end this command or alter your option.
Details in code:
Please look at src/libecryptfs
It will prompt user to enter the selection which is set to "val" variable and then run into "else" portion instead of "if" portion. However, "node->
Reason:
1) User doesn't install openssl module.
2) The developers of ecryptfs-manager doesn't take such case into consideration.
Quote from Tyler (see https:/
"> Option 3 allows to generate a new public/private key pair, but asks for
> a key type without giving the slightest hint about what type choices
> there are.
That's because you don't have the OpenSSL key module installed. The
ecryptfs-manager prompts should take this into account, but they don't.
Please consider filing a separate bug about this."
Because of that, I'm opening this bug report!
Related branches
- Tyler Hicks: Approve
- Jason Xing (community): Needs Resubmitting
-
Diff: 15 lines (+5/-0) 1 file modifiedapisrc/libecryptfs/decision_graph.c (+5/-0)
I'm assigning this to me...Any advice and comments are welcome!
It has something to do with bug 878239.
- selects the third option
+ ecryptfs-manager runs into infinite loop if user doesn't install openssl
+ and selects the third option
I'm done with that patch.
The first attachment is the original outputs if you run ecryptfs-manager and then select 3.
The second attachment is the outputs after writing the patch in decision_graph.c to prevent infinite loop. It will prompt user with error message.
Committed to lp:ecryptfs as r888. Thanks for the fix!