You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Pass class's public function as an argument to external command

I am trying to write a library for encoders.

main.ino:

#include <./Encoders.h>
Encoders encoders();
void setup(){
 Serial.begin(9600);
}
void loop(){ 
 Serial.print("");
}

Encoders.h:

#ifndef Encoders_h
#define Encoders_h
#include "Arduino.h"
class Encoders{
 public:
 Encoders();
 void EncodersSetup();
 long RightCount;
 long LeftCount;
 void R_A_RISE();
 void R_A_FALL();
 void R_B_RISE();
 void R_B_FALL();
 void L_A_RISE();
 void L_A_FALL();
 void L_B_RISE();
 void L_B_FALL();
 private:
 short R_A_SIG, R_B_SIG, L_A_SIG, L_B_SIG;
};
#endif

Encoders.cpp

#include "Arduino.h"
#include "Encoders.h"
long RightCount;
long LeftCount;
long R_A_SIG, R_B_SIG, L_A_SIG, L_B_SIG;
Encoders::Encoders(){
 attachInterrupt(0, R_A_RISE, RISING);
 attachInterrupt(1, R_B_RISE, RISING);
 attachInterrupt(2, L_A_RISE, RISING);
 attachInterrupt(3, L_B_RISE, RISING);
 R_A_RISE();
}
void Encoders::R_A_RISE(){
 detachInterrupt(0);
 R_A_SIG = 1;
 if(R_B_SIG == 0){
 RightCount++;
 }
 if(R_B_SIG == 1){
 RightCount--;
 }
 attachInterrupt(0, R_A_FALL, FALLING);
}
void Encoders::R_A_FALL(){
 detachInterrupt(0);
 R_A_SIG = 0;
 if(R_B_SIG == 1){
 RightCount++;
 } 
 if(R_B_SIG == 0){
 RightCount--;
 }
 attachInterrupt(0, R_A_RISE, RISING);
}
void Encoders::R_B_RISE(){
 detachInterrupt(1);
 R_B_SIG = 1;
 if(R_A_SIG == 1){
 RightCount++;
 }
 if(R_A_SIG == 0){
 RightCount--;
 }
 attachInterrupt(1, R_B_FALL, FALLING);
}
void Encoders::R_B_FALL(){
 detachInterrupt(1);
 R_B_SIG = 0;
 if(R_A_SIG == 0){
 RightCount++;
 }
 if(R_A_SIG == 1){
 RightCount--;
 } 
 attachInterrupt(1, R_B_RISE, RISING);
}
void Encoders::L_A_RISE(){
 detachInterrupt(2);
 L_A_SIG = 1;
 if(L_B_SIG == 0){
 LeftCount++;
 }
 if(L_B_SIG == 1){
 LeftCount--;
 }
 attachInterrupt(2, L_A_FALL, FALLING);
}
void Encoders::L_A_FALL(){
 detachInterrupt(2);
 L_A_SIG = 0;
 if(L_B_SIG == 1){
 LeftCount++;
 } 
 if(L_B_SIG == 0){
 LeftCount--;
 }
 attachInterrupt(2, L_A_RISE, RISING); 
}
void Encoders::L_B_RISE(){
 detachInterrupt(3);
 L_B_SIG = 1;
 if(L_A_SIG == 1){
 LeftCount++;
 }
 if(L_A_SIG == 0){
 LeftCount--;
 }
 attachInterrupt(3, L_B_FALL, FALLING);
}
void Encoders::L_B_FALL(){
 detachInterrupt(3);
 L_B_SIG = 0;
 if(L_A_SIG == 0){
 LeftCount++;
 }
 if(L_A_SIG == 1){
 LeftCount--;
 } 
 attachInterrupt(3, L_B_RISE, RISING);
}

When I try to compile this, I get errors like this:

C:/Users/marcel/Documents/dev/Arduino/encodeurs/Encoders.cpp:10:38: error: cannot convert 'Encoders::R_B_RISE' from type 'void (Encoders::)()' to type 'void (*)()'

I tried answers on other threads. Most said to make the functions passed to attachInterrupt() static. That threw different errors:

C:/Users/marcel/Documents/dev/Arduino/encodeurs/Encoders.cpp:16:33: error: cannot declare member function 'void Encoders::R_A_RISE()' to have static linkage [-fpermissive]

I also tried this:

attachInterrupt(0, &Encoders::R_A_RISE, this, RISING);

with no success.

The Arduino in question is a Mega but I doubt that matters.

Edit: Per Nick Gammon's answer, I now have this.

MotorEncoderMaster.ino

#include </home/marcel/dev/Arduino/encoders/MotorEncoderMaster/Encoders.h>
Encoders * Encoders::instances [2] = { NULL, NULL };
// instances of our class
Encoders right;
Encoders left;
void setup (){
 right.begin (2); // pin D2
 left.begin (3); // pin D3
} // end of setup
void loop (){
 // whatever
} // end of loop

Encoders.h:

class Encoders{
 volatile bool switchChanged;
 static Encoders * instances [2];
 static void switchPressedExt0(){
 if(Encoders::instances [0] != NULL){
 Encoders::instances [0]->switchPressed();
 }
 }
 static void switchPressedExt1 (){
 if (Encoders::instances [1] != NULL){
 Encoders::instances [1]->switchPressed();
 }
 }
 public:
 void begin (const int whichPin){
 pinMode (whichPin, INPUT_PULLUP);
 switch (whichPin){
 case 2:
 attachInterrupt(0, switchPressedExt0, CHANGE);
 instances [0] = this;
 break;
 case 3:
 attachInterrupt(1, switchPressedExt1, CHANGE);
 instances [1] = this;
 break;
 }
 }
 void switchPressed(){
 switchChanged = true;
 }
};

When I try to compile this, I get :

In file included from MotorEncoderMaster.ino:1:0:
/home/marcel/dev/Arduino/encoders/Encoders.h: In static member function ‘static void Encoders::switchPressedExt0()’:
/home/marcel/dev/Arduino/encoders/Encoders.h:7:34: error: ‘NULL’ was not declared in this scope
 if(Encoders::instances [0] != NULL){
 ^
/home/marcel/dev/Arduino/encoders/Encoders.h: In static member function ‘static void Encoders::switchPressedExt1()’:
/home/marcel/dev/Arduino/encoders/Encoders.h:13:35: error: ‘NULL’ was not declared in this scope
 if (Encoders::instances [1] != NULL){
 ^
/home/marcel/dev/Arduino/encoders/Encoders.h: In member function ‘void Encoders::begin(int)’:
/home/marcel/dev/Arduino/encoders/Encoders.h:21:24: error: ‘INPUT_PULLUP’ was not declared in this scope
 pinMode (whichPin, INPUT_PULLUP);
 ^
/home/marcel/dev/Arduino/encoders/Encoders.h:21:36: error: ‘pinMode’ was not declared in this scope
 pinMode (whichPin, INPUT_PULLUP);
 ^
/home/marcel/dev/Arduino/encoders/Encoders.h:24:45: error: ‘CHANGE’ was not declared in this scope
 attachInterrupt(0, switchPressedExt0, CHANGE);
 ^
/home/marcel/dev/Arduino/encoders/Encoders.h:24:51: error: ‘attachInterrupt’ was not declared in this scope
 attachInterrupt(0, switchPressedExt0, CHANGE);
 ^

Answer*

# Interrupt Service Routine (ISR) outside a class

Let's consider a simple use of interrupts:

 volatile bool switchChanged;
 
 void switchPressed ()
 {
 switchChanged = true;
 } // end of switchPressed
 
 void setup ()
 {
 pinMode (2, INPUT_PULLUP);
 attachInterrupt (0, switchPressed, CHANGE);
 } // end of setup
 
 void loop ()
 {
 // whatever 
 } // end of loop

That compiles fine.

---

# ISR inside a class as a class function (method)

Now let's imagine we want to put the interrupt handling into a class for our convenience.


 class myClass
 {
 volatile bool switchChanged;
 
 public:
 
 void begin ()
 {
 pinMode (2, INPUT_PULLUP);
 attachInterrupt (0, switchPressed, CHANGE); // <--- line 10
 } // end of myClass::begin
 
 void switchPressed ()
 {
 switchChanged = true;
 } // end of myClass::switchPressed
 
 }; // end of class myClass
 
 myClass foo; // make an instance of myClass
 
 void setup ()
 {
 foo.begin ();
 } // end of setup
 
 void loop ()
 {
 // whatever 
 } // end of loop

That does **not** compile:

 ISR_in_class_test.ino: In member function ‘void myClass::begin()’:
 ISR_in_class_test:10: error: argument of type ‘void (myClass::)()’ does not match ‘void (*)()’

What is going on here?

ISRs have to be static functions, taking no arguments. However (non-static) class functions have an implied `this->` pointer which points to the particular *instance* of the class.

For example, if we have two instances:


 myClass foo; 
 myClass bar; 

If we call foo.begin() then `this->` points to "foo", and if we call bar.begin then `this->` points to "bar".

However an ISR, when fired by the processor, cannot know whether `this->` is "foo" or "bar" or something else. Thus the compiler cannot compile that line.

---

# ISR inside a class as a static class function

We can try to work around this by making the class function **static**. Doing that means that the function is not tied to any particular instance, and thus the attachInterrupt line will compile.


 class myClass
 {
 volatile bool switchChanged; // <--- line 3
 
 public:
 
 void begin ()
 {
 pinMode (2, INPUT_PULLUP);
 attachInterrupt (0, switchPressed, CHANGE);
 } // end of myClass::begin
 
 static void switchPressed ()
 {
 switchChanged = true; // <--- line 15
 } // end of myClass::switchPressed
 
 }; // end of class myClass
 
 myClass foo; // make an instance of myClass
 
 void setup ()
 {
 foo.begin ();
 } // end of setup
 
 void loop ()
 {
 // whatever 
 } // end of loop

However now we have a different problem:

 ISR_in_class_test.ino: In static member function ‘static void myClass::switchPressed()’:
 ISR_in_class_test:3: error: invalid use of member ‘myClass::switchChanged’ in static member function
 ISR_in_class_test:15: error: from this location

A non-static class variable cannot be called from a static class function. Why? Because the compiler doesn't know *which* variable you want. Is it `foo.switchChanged` or `bar.switchChanged`?

---

# ISR inside a class as a static class function with static variables

To make the static function work, it can only access static variables. So we can make switchChanged static. Plus we need to define an instance of this static variable.

 class myClass
 {
 static volatile bool switchChanged; // declare
 
 public:
 
 void begin ()
 {
 pinMode (2, INPUT_PULLUP);
 attachInterrupt (0, switchPressed, CHANGE);
 } // end of myClass::begin
 
 static void switchPressed ()
 {
 switchChanged = true;
 } // end of myClass::switchPressed
 
 }; // end of class myClass
 
 volatile bool myClass::switchChanged; // define
 
 myClass foo; // make an instance of myClass
 
 void setup ()
 {
 foo.begin ();
 } // end of setup
 
 void loop ()
 {
 // whatever 
 } // end of loop

Now the class compiles. However we have thrown away most of the advantages of having a class in the first place, as we are forced to use a static function, and that static function can only access static variables.

---

# Glue routines

To work around this problem we can write short "glue" routines. These are functions that interface between an ISR and an **instance** of a class.



 class myClass
 {
 volatile bool switchChanged;
 
 static myClass * instances [2];
 
 static void switchPressedExt0 ()
 {
 if (myClass::instances [0] != NULL)
 myClass::instances [0]->switchPressed ();
 } // end of myClass::switchPressedExt0
 
 static void switchPressedExt1 ()
 {
 if (myClass::instances [1] != NULL)
 myClass::instances [1]->switchPressed ();
 } // end of myClass::switchPressedExt1
 
 
 public:
 
 void begin (const byte whichPin)
 {
 pinMode (whichPin, INPUT_PULLUP);
 switch (whichPin)
 {
 case 2: 
 attachInterrupt (0, switchPressedExt0, CHANGE);
 instances [0] = this;
 break;
 
 case 3: 
 attachInterrupt (1, switchPressedExt1, CHANGE);
 instances [1] = this;
 break;
 
 } // end of switch
 } // end of myClass::begin
 
 void switchPressed ()
 {
 switchChanged = true; 
 }
 
 }; // end of class myClass
 
 myClass * myClass::instances [2] = { NULL, NULL };
 
 // instances of our class 
 myClass foo; 
 myClass bar;
 
 void setup ()
 {
 foo.begin (2); // pin D2
 bar.begin (3); // pin D3
 } // end of setup
 
 void loop ()
 {
 // whatever 
 } // end of loop

This is a bit fiddly, however what it is doing is remembering in an array which instance of the class is associated with which interrupt. The "glue" routines switchPressedExt0 and switchPressedExt1 call the appropriate instance of the switchPressed function by using the remembered class pointer.

Now the non-static function switchPressed can access non-static class variables.

---

Adapted from my web page [Calling an ISR from a class](http://www.gammon.com.au/forum/?id=12983)

Draft saved

Draft discarded

Edit Summary*

Cancel

The whole point of this was to break my code into multiple files. When I put the class declaration in a different file and #include it, I get this error: pastebin.com/TkBCG74G. Is there a way to declare the class in another file and not break everything?

Marcel
– Marcel

2016年02月13日 18:43:00 +00:00
Commented Feb 13, 2016 at 18:43
Of course. However not seeing your code it is hard to advise.

Nick Gammon
– Nick Gammon ♦

2016年02月13日 21:22:35 +00:00
Commented Feb 13, 2016 at 21:22
Code: bitbucket.org/MarcelRobitaille/encoders

Marcel
– Marcel

2016年02月14日 03:55:54 +00:00
Commented Feb 14, 2016 at 3:55
See my reply here Classes and objects: how many and which file types do I actually need to use them? - you don't need to include .ino files - the IDE does that for you (if they are in the same folder). Also don't call your files "main.xxx".

Nick Gammon
– Nick Gammon ♦

2016年02月14日 04:10:47 +00:00
Commented Feb 14, 2016 at 4:10
Rename your file Encoders.ino to be Encoders.h and include that into your main file. Rename your main file to be something other than main.ino. Then it compiles.

Nick Gammon
– Nick Gammon ♦

2016年02月14日 04:15:09 +00:00
Commented Feb 14, 2016 at 4:15

| Show 16 more comments

How to Edit

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

How to Format

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »

How to Tag

A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.

complete the sentence: my question is about...
use tags that describe things or concepts that are essential, not incidental to your question
favor using existing popular tags
read the descriptions that appear below the tag

If your question is primarily about a topic for which you can't find a tag:

combine multiple words into single-words with hyphens (e.g. arduino-uno), up to a maximum of 35 characters
creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you

popular tags »

lang-cpp