Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

py.RunFile / RunCode doesn't handle a nil module pointer #249

Open
@SolarLune

Description

Hey, there. It's really cool to be able to run Python in Go! I'd like to congratulate you on this project, it might be exactly what I've been looking for when it comes to an easily embeddable scripting language.

I just noticed that py.RunFile() and py.RunCode() don't handle a nil py.Module pointer when deciding to create a new module. I feel like that would lessen the friction on using it, since if you run multiple files and want them to be in a single module you currently have to call two different RunFile() / RunCode() calls that are essentially the same (just with nil as the inModule argument the first time).

Basically, currently I'm doing this:

var mod *py.Module
...
// In a for loop for mutliple .py files
if mod == nil {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, nil) // Returns a new module
} else {
	mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Adds onto the existing one
}

and it would be easier to just do this:

var mod *py.Module
...
mod, err = py.RunFile(context, fpath, py.CompileOpts{UseSysPaths: true}, mod) // Returns a new module on first run because 'mod' is nil, adds onto the existing module afterwards

I believe to implement this I would just need to modify RunCode() to check for nil in the case *Module part of the inModule type check. Does this sound OK?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /