Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Help wanted][Enhancement] Refactor condition matchers #12

Open
Labels
@hezean

Description

private static final Map<PredicateType, StringMatcher> stringMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, SegmentMatcher> segmentMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, DatetimeMatcher> datetimeMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, NumberMatcher> numberMatchers = new EnumMap<>(PredicateType.class);
private static final Map<PredicateType, SemverMatcher> semverMatchers = new EnumMap<>(PredicateType.class);

using map for predicate matching isn't a good practice, consider using strategy pattern or so.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /