I came up with a hack to escape HTML using jQuery and I'm wondering if anyone sees a problem with it.
$('<i></i>').text(TEXT_TO_ESCAPE).html();
The <i>
tag is just a dummy as jQuery needs a container to set the text of.
Is there perhaps an easier way to do this? Note that I need the text stored in a variable, not for display (otherwise I could just call elem.text(TEXT_TO_ESCAPE);
).
Thanks!
3 Answers 3
That's a pretty standard way of doing it, my version used a <div>
though:
return $('<div/>').text(t).html();
This isn't technically 100% safe though as Mike Samuel notes but it is probably pretty safe in practice.
The current Prototype.js does this:
function escapeHTML() {
return this.replace(/&/g,'&').replace(/</g,'<').replace(/>/g,'>');
}
But it used to use the "put text in a div and extract the HTML" trick.
There's also _.escape
in Underscore, that does it like this:
// List of HTML entities for escaping.
var htmlEscapes = {
'&': '&',
'<': '<',
'>': '>',
'"': '"',
"'": ''',
'/': '/'
};
// Regex containing the keys listed immediately above.
var htmlEscaper = /[&<>"'\/]/g;
// Escape a string for HTML interpolation.
_.escape = function(string) {
return ('' + string).replace(htmlEscaper, function(match) {
return htmlEscapes[match];
});
};
That's pretty much the same approach as Prototype's. Most of the JavaScript I do lately has Underscore available so I tend to use _.escape
these days.
-
3A lot of libraries do this. Just be aware that the result here is safe to embed in a PCDATA context and an RCDATA context, but not an attribute context since quotes are not escaped. If you might be susceptible to UTF-7 attacks and the like you should also escape '+': en.wikipedia.org/wiki/UTF-7#SecurityMike Samuel– Mike Samuel2011年05月16日 20:24:41 +00:00Commented May 16, 2011 at 20:24
-
6@Mike: I don't think the
.text(t).html()
or Prototype'sreplace
approaches are really that great, both approaches have problems. The lack of aencodeHTML()
function in the standard JavaScript library is a gaping hole and a rather surprising oversight.mu is too short– mu is too short2011年05月16日 20:33:31 +00:00Commented May 16, 2011 at 20:33 -
@muis: I don't think so: the core JavaScript language is not specifically aimed at web browsers.Marcel Korpel– Marcel Korpel2011年05月17日 20:33:15 +00:00Commented May 17, 2011 at 20:33
-
4@Marcel: But we do have
encodeURIComponent
and JavaScript's roots are in web browsers. And, the fact that everyone ends up writing their own indicates that there is a gap in the standard libraries.mu is too short– mu is too short2011年05月17日 21:57:44 +00:00Commented May 17, 2011 at 21:57 -
@muis Thanks for the pointer to Prototype. It turns out that my proposed method doesn't work as I expect in some browsers (read: IE)Michael Mior– Michael Mior2011年05月18日 05:16:34 +00:00Commented May 18, 2011 at 5:16
There is no guarantee that html()
will be completely escaped so the result might not be safe after concatenation.
html()
is based on innerHTML
, and a browser could, without violating lots of expectations, implement innerHTML
so that $("<i></i>").text("1 <").html()
is "1 <"
, and that $("<i></i>").text("b>").html()
is "b>"
.
Then if you concatenate those two individually safe results, you get "1 <b>"
which will obviously not be the HTML version of the concatenation of the two plaintext pieces.
So, this method is not safe by deduction from first principles, and there's no widely followed spec of innerHTML
(though HTML5 does address it).
The best way to check if it does what you want is to test corner cases like this.
-
Actually, I want
$("<i></i>").text("1 <").html()
to be"1 <"
and$("<i></i>").text("b>").html()
to be"b>"
. (which works)Michael Mior– Michael Mior2011年05月16日 17:07:44 +00:00Commented May 16, 2011 at 17:07 -
1@Michael, if you've tested it on major browsers, and it works, great. As of 15 June, 2009, a current version of Safari actually unescaped > so
<input name="Hello>World">
was returned viainnerHTML
as<input name="Hello>World">
. That may have been fixed in modern browsers though. My point is that testing is the way to gain confidence.Mike Samuel– Mike Samuel2011年05月16日 17:55:16 +00:00Commented May 16, 2011 at 17:55
That should work. That's basically how the Prototype.js library does it, or at least how it used to do it. I generally do it with three calls to ".replace()" but that's mostly just a habit.
<
,>
and&
to their corresponding HTML entities?$('<i>').text(TEXT_TO_ESCAPE).html();