homepage

Dear Python Patch Center:
This is my first Python patch submission. Apologies for
any errors of protocol. I have been using these
submitted changes for several years and have even given
it out (I mentioned it a few years back on a python
mailing list.) I am confident to the best of my ability
that these changes are solid.
Unfortunately I don't have the capability of rebuilding
the documentation, but the changes to the documentation
are outlined below.
Please do not hesitate to contact me for further
information or assistance. I would be honored to have
these changes become part of some Python revision, be
it 2.5 or something further in the future.
Thank you,
Eric Woudenberg
eaw@connact.com
From my version of the wave.py file:
These changes allow .wav files containing u-law and
a-law data to be read and written. The user visible
changes are:
1) After a .wav file containing mu-law or a-law data is
opened for reading, a call to getcomptype() returns
'ULAW' (resp. 'ALAW') and a call to getcompname()
returns 'CCITT G.711 u-law' (resp. 'CCITT G.711 a-law').
2) After a wave object is created for writing,
setcomptype() can be called with the arguments ('ULAW',
'CCITT G.711 u-law') (resp. 'ALAW', 'CCITT G.711
a-law'). The second argument (text description) is ignored.
3) The comptype 'PCM' is now a synonym for 'NONE'.
PCM-containing wave files will return 'PCM' instead of
'NONE' for their comptype.
 
Note that this module does not do any u-law or a-law
format conversion to PCM, it simply allows users to
read or write u-law/a-law data from/to .wav files that
have conforming headers. For audio conversion of PCM
data to or from u-law, use the audioop module.

Patch applied to Python 2.4 wave.py

Patch applied to Python 2.5 wave.py

Please read http://www.python.org/dev/patches/
The best format for a patch is a "diff -u" format. It's much much easier
to see what you changed to the existing code, and the same patch often
applies to several versions.
Also, 2.4 and 2.5 are closed for new developments - your changes would
only go to a 2.7 version.
And your change is more likely to be accepted if it contains unit tests
(in Lib/test/test_wave.py)

For consistency with the aifc and sunau modules the wave module should compress/uncompress u-law and A-law data.