WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-users

[Top] [All Lists]

Re: [Xen-users] Credit Scheduler!

To: Hardeep Singh <hardeepguru@xxxxxxxxx>
Subject: Re: [Xen-users] Credit Scheduler!
From: Emmanuel Ackaouy <ack@xxxxxxxxxxxxx>
Date: 2006年6月30日 17:16:49 +0100
Cc: John Levin <xenjohn@xxxxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx, Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Delivery-date: 2006年6月30日 09:18:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <77d78aa70606300749t4c3b32del9f4e5433be31db3e@xxxxxxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Hardeep Singh <hardeepguru@xxxxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx, Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>, John Levin <xenjohn@xxxxxxxxx>
References: <77d78aa70606300749t4c3b32del9f4e5433be31db3e@xxxxxxxxxxxxxx>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Jun 30, 2006 at 09:49:57AM -0500, Hardeep Singh wrote:
> root@pippin:/home/hardeep# xm sched-credit -d vm1 -w 10
>
> (XEN) BUG at sched_credit.c:757
Ok I found the problem and submitted a fix to the staging
tree. It should trickle out to the public tree in a couple
hours when it's gone through the regression tests.
In the meantime, here's a patch if you don't want to wait.
diff -r 3dfc2583a4f1 xen/common/sched_credit.c
--- a/xen/common/sched_credit.c Thu Jun 29 16:59:47 2006 +0100
+++ b/xen/common/sched_credit.c Fri Jun 30 16:56:17 2006 +0100
@@ -622,9 +622,12 @@ csched_dom_cntl(
 
 if ( cmd->u.credit.weight != 0 )
 {
- csched_priv.weight -= sdom->weight;
+ if ( !list_empty(&sdom->active_sdom_elem) )
+ {
+ csched_priv.weight -= sdom->weight;
+ csched_priv.weight += cmd->u.credit.weight;
+ }
 sdom->weight = cmd->u.credit.weight;
- csched_priv.weight += sdom->weight;
 }
 
 if ( cmd->u.credit.cap != (uint16_t)~0U )
_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-users] XEON VT Support , Terje J. Hanssen
Next by Date: [Xen-devel] Re: [Xen-users] Credit Scheduler! , Hardeep Singh
Previous by Thread: RE: [Xen-users] Credit Scheduler! , Petersson, Mats
Next by Thread: Re: [Xen-users] Credit Scheduler! , Hardeep Singh
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /