WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug

To: "Jinsong Liu" <jinsong.liu@xxxxxxxxx>
Subject: RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: 2011年3月08日 10:14:08 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx>, Xin Li <xin.li@xxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxx>
Delivery-date: 2011年3月08日 02:17:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BC00F5384FCFC9499AF06F92E8B78A9E1FABB28525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BC00F5384FCFC9499AF06F92E8B78A9E1FA4F5A806@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C9967421.14234%keir.xen@xxxxxxxxx> <4D75FC5702000078000351B2@xxxxxxxxxxxxxxxxxx> <BC00F5384FCFC9499AF06F92E8B78A9E1FABB28525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 08.03.11 at 10:47, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> Jan, I'm not quite clear your meaning.
> Why and where need to insert barrier, or volatile cpu_state?
 
 while ( (seen_state = cpu_state) != CPU_STATE_DEAD )
 {
+ barrier();
 BUG_ON(seen_state != CPU_STATE_DYING);
 mdelay(100);
 cpu_relax();
Without this, the compiler is free to eliminate "seen_state" in favor
of reading "cpu_state" twice (irrespective of the optimizer very
likely trying to do exactly the opposite).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] Re: [PATCH 2/3] xen-balloon: Add interface to retrieve ballooned pages , Ian Campbell
Next by Date: [Xen-devel] Re: [PATCH 1/3] xen-balloon: Move core balloon functionality out of module , Ian Campbell
Previous by Thread: RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug , Liu, Jinsong
Next by Thread: Re: [Xen-devel] Re: [PATCH] Fix cpu offline bug , Keir Fraser
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /