WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2

To: Daniel Stodden <daniel.stodden@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: 2010年1月29日 10:34:44 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: 2010年1月29日 02:35:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1264718262@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1264718262@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010年01月28日 at 22:37 +0000, Daniel Stodden wrote:
> - Does a runtime kernel version check. I guess this code will
> need additional cpp magic on BSDs. 
I guess BSD will need cpp magic regardless of the kernel version check
since it will have a different interface altogether. But for the Linux
version can we not just try eventfd(), check for -ENOSYS and fall back
to the old way if necessary, instead of hardcoding the kernel version?
I suppose eventfd is an unlikely candidate for backporting to anything
older but in general IMHO it's preferable to check for the actual
functionality you want to use rather than hardcoding version numbers
etc.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2 , Daniel Stodden
Next by Date: [Xen-devel] Re: Test results for save/restore with upstream pv_ops domU kernels , Ian Campbell
Previous by Thread: Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2 , Daniel Stodden
Next by Thread: Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2 , Daniel Stodden
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /