On 21/01/2010 20:38, "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx> wrote:
>> You introduced the magic port value check, in xen-unstable:19964.
>
> I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> how the unmodified drivers part of the change relates to the comment :-(
Yes, I wonder if it was even meant to be checked in. Or if it's an
accidental merge of two patches both of which you intended to go in.
I'm not sure unconditional unplug, as implemented, is a good idea. I can
imagine people with setups in which emulated devices coexist with pv
devices. Such a setup breaks if emulated devices all get unplugged when pv
drivers load. Presumably in the environment this patch came from (Citrix
XenServer) such a situation is disallowed, but I'm not so sure about
proscribing it more generally.
Some people do want unplug though, so I think making it a non-default module
option is a good idea.
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel