On 16/09/2009 09:44, "Yang, Sheng" <sheng.yang@xxxxxxxxx> wrote:
> Hi Keir & Jeremy
>
> Here is the hypervisor part of hybrid extension support.
>
> Please review, thanks!
The principle is okay I guess. These changes would have to be trickled in
with a really good explanation and justification for each one. For example,
I'm not clear why the enable-hybrid hypercall is needed. Why not just
provide access to evtchn and timer hypercalls always, and guest sues them if
it is capable of it? I'm also not sure why PV timer events get routed to
irq0 -- why not via an event channel as usual, now that you are enabling HVM
guests to use the evtchn subsystem? What's a hybrid gnttab, and why does it
need an explciit reserved e820 region? And so on.
The general principle of these patches seems to be to create a set of
individual, and perhaps largely independent, accelerations/enlightenments to
the HVM interface. I can at least agree with and support that aim.
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel