WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] RE: About CONFIG_ACPI_PROCESSOR_XEN

To: Gianluca Guida <gianluca.guida@xxxxxxxxxx>
Subject: [Xen-devel] RE: About CONFIG_ACPI_PROCESSOR_XEN
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: 2009年8月25日 00:30:14 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Delivery-date: 2009年8月24日 09:30:43 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19090.44179.307374.533766@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19090.38074.148633.400137@xxxxxxxxxxxxxxxxxxxxxxxxx> <4D05DB80B95B23498C72C700BD6C2E0B33689A03@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <19090.44179.307374.533766@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acok0B5meI2k504zRlGY24HwcCG98gAB6ZUQ
Thread-topic: About CONFIG_ACPI_PROCESSOR_XEN
Ha, I see, then the following simple patch should fix this issue, but this will 
limit CONFIG_ACPI_PROCESSOR to be y. I am still thinking if there is better fix 
to allow CONFIG_ACPI_PROCESSOR=m.
diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
index 33976f7..2e7d673 100644
--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -98,5 +98,5 @@ config XEN_MCE
 config ACPI_PROCESSOR_XEN
 bool
- depends on XEN_DOM0 && ACPI_PROCESSOR && CPU_FREQ
+ depends on XEN_DOM0 && ACPI_PROCESSOR = y && CPU_FREQ
 default y
-----Original Message-----
From: Gianluca Guida [mailto:gianluca.guida@xxxxxxxxxx] 
Sent: Monday, August 24, 2009 11:07 PM
To: Yu, Ke
Cc: Gianluca Guida; Tian, Kevin; Jeremy Fitzhardinge; 
xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: About CONFIG_ACPI_PROCESSOR_XEN
Hi Ke,
Yu, Ke writes:
 > Thanks for trying and reporting this issue. The root cause of the 
 > compilation issue is found as: "when CONFIG_ACPI_PROCESSOR_XEN is not set, 
 > the <include/acpi/processor.h> is not included, thus the "struct 
 > acpi_processor" is not defined, which will cause compiling error for inline 
 > function processor_cntl_xen_prepare(struct acpi_processor *pr);"
Hm no, I was not referring to the compilation warning. I've also made
a mistake on explaining the problem. :-)
So, the problem is that when CONFIG_ACPI_PROCESSOR is set to 'm',
CONFIG_ACPI_PROCESSOR_XEN will be set (being bolean, to 'y'). This
will cause the final linking to fail because of undefined symbols
(those now in the module called in the xen acpi code).
Here's what happens in my .config:
CONFIG_ACPI_PROCESSOR=m
[...]
CONFIG_ACPI_PROCESSOR_XEN=y
And this is the result:
LD .tmp_vmlinux1
drivers/built-in.o: In function `processor_cntl_xen_prepare':
(.text+0x543e8): undefined reference to `acpi_processor_get_performance_info'
drivers/built-in.o: In function `processor_cntl_xen_prepare':
(.text+0x5440c): undefined reference to `acpi_processor_get_psd'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2
As of your patch, yes that's useful to remove the warning.
Cheers,
Gianluca
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] Xen Paravirt Operations Domain 0 Serial Console Problem , Mr. Teo En Ming (Zhang Enming)
Next by Date: Re: [Xen-devel] softtsc for PV guests , Jeremy Fitzhardinge
Previous by Thread: [Xen-devel] RE: About CONFIG_ACPI_PROCESSOR_XEN , Gianluca Guida
Next by Thread: [Xen-devel] RE: About CONFIG_ACPI_PROCESSOR_XEN , Gianluca Guida
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /