WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: 2009年7月30日 11:14:04 +0100
Cc:
Delivery-date: 2009年7月30日 03:14:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907301112.15209.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoQ9eyK0m4g/BrDSgGR+AoGoPFhDwACIqaG
Thread-topic: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
User-agent: Microsoft-Entourage/12.20.0.090605
On 30/07/2009 10:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> Make (set|get)_xen_guest_handle() always available.
> This avoids code snippets in the guest like this:
>
> #if __XEN_ITNERFACE_VERSION__ >= 0x00030201
> set_xen_guest_handle(hnd, val);
> #else
> hnd = val;
> #endif
Actually I don't see why you'd have code like this. *You*, the guest, gets
to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so
ifdef'ing based on it in the guest is stupid.
Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest
handles, and then remove your ifdefs. Simple.
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available , Keir Fraser
Next by Date: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available , Christoph Egger
Previous by Thread: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available , Keir Fraser
Next by Thread: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available , Christoph Egger
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /