| To: | Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xen: more robust serial port driver |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | 2009年7月28日 15:15:42 +0100 |
| Cc: | |
| Delivery-date: | 2009年7月28日 07:16:37 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200907281607.06109.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcoPjN77Aess9kIXTaeNzDsCAt9sUQAAQTO/ |
| Thread-topic: | [Xen-devel] [PATCH] xen: more robust serial port driver |
| User-agent: | Microsoft-Entourage/12.20.0.090605 |
On 28/07/2009 15:07, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > > Attached patch adds a check if the fifo is usable before we > actually use it. I count that at least the first two chunks and the initialisation of tx_fifo_size are unnecessary. Might this be the case for the udelay(100) as well? And what kinds of systems have these broken UARTs that half-advertise a broken/non-existent FIFO? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Strange network behaviour , George Dunlap |
|---|---|
| Next by Date: | Re: [Xen-devel] Strange network behaviour , Marco Tizzoni |
| Previous by Thread: | [Xen-devel] [PATCH] xen: more robust serial port driver , Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] xen: more robust serial port driver , Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |