| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] RE: [PATCH] Fix xentop on pv-ops domain0 |
| From: | Steven Maresca <steve.maresca@xxxxxxxxx> |
| Date: | Mon, 6 Jul 2009 10:50:40 -0400 |
| Cc: | dongxiao.xu@xxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, echo@xxxxxxxxxxxx |
| Delivery-date: | 2009年7月06日 08:17:26 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=JH5outpO/16pNceapIReaSnlztOSV1Da7A1IKgwpqAw=; b=DhMHsvc/89idt1gGK/9GQ62eX+IB4pEy6t0wAX3nVSGS+d63XSnIe9XeTh3fWnVYQr ++1m/2p6mrXYV73BasPfIh33IuLfRPOWhA8wlXV4iiNiNZXvl+iaeYyx0PbB/w8uyOcH VIw8a+ORFUEs0wNSnqDvZhzmAbS4J7F0LjrWU= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; b=RoCa+tHrzkuj5f8M/wY2/sXeDkIf+9QknUw3Pu+XRuamQM/um5alHQUrgRet82E1/0 CF5tBj175R08Se05vpzzUerJvcrAdZr6ts0lyX3tyiCcQOUPGFl39lB2WA/FVAPnSnEP 7XhXXRZJZXO/1qcDLsvHBio1taHqVvZTcmhqo= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hello, >Xentop encounters error in pv-ops domain0, because the VBD path in sysfs >changes to "/sys/devices" >Also delete the macro in xenstat_netbsd.c, because it is not used. > >Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx> > >Best Regards, >-- Dongxiao The patch you've provided explicitly checks for a .18-xen kernel; doing so runs the risk of breaking behavior on every forward port after .18. This is quite fragile. It is my suggestion that, instead, we might utilize the patch Ian Campbell suggested some time ago. See http://lists.xensource.com/archives/html/xen-devel/2009-05/msg00299.html That patch is a small tweak: #define SYSFS_VBD_PATH "/sys/bus/xen-backend/devices" Luckily, this change satisfies legacy .18-xen, pvops, (and even older .16-xen kernels), Xenstat - while useful - is brittle enough as it is, so keeping things generic would be best. -Steve Maresca _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] 32-on-64 support in xen-unstable? , Chris Lalancette |
|---|---|
| Next by Date: | [Xen-devel] Xen pv kernel (2.6.30) causes s2ram to crash with segmentation fault , Tom Rotenberg |
| Previous by Thread: | [Xen-devel] How can I boot windows with graphics card support on xen no-iommu , Flykey |
| Next by Thread: | [Xen-devel] Xen pv kernel (2.6.30) causes s2ram to crash with segmentation fault , Tom Rotenberg |
| Indexes: | [Date] [Thread] [Top] [All Lists] |