| To: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH] Fix bugs in xc_exchange_page |
| From: | "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> |
| Date: | Thu, 2 Jul 2009 14:48:01 +0800 |
| Accept-language: | en-US |
| Acceptlanguage: | en-US |
| Cc: | Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | 2009年7月01日 23:49:34 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acn64Qqx36L1Z4K8QcCUUDk+FVoQAw== |
| Thread-topic: | [PATCH] Fix bugs in xc_exchange_page |
Followed patch fix wrong usage for pfn_type. Otherwise xc_exchange_page is sure
to seg fault.
Thanks
Yunhong, Jiang
The pfn_type is indexed by gpfn, not mfn.
Signed-off-by: Jiang, Yunhong <yunhong.jiang@xxxxxxxxx>
diff -r 02003bee3e80 tools/libxc/xc_offline_page.c
--- a/tools/libxc/xc_offline_page.c Thu Jun 25 18:31:10 2009 +0100
+++ b/tools/libxc/xc_offline_page.c Thu Jul 02 00:55:41 2009 +0800
@@ -583,7 +583,7 @@ int xc_exchange_page(int xc_handle, int
/* Don't exchange CR3 for PAE guest in PAE host environment */
if (minfo.guest_width > sizeof(long))
{
- if ( (minfo.pfn_type[mfn] & XEN_DOMCTL_PFINFO_LTABTYPE_MASK) ==
+ if ( (minfo.pfn_type[gpfn] & XEN_DOMCTL_PFINFO_LTABTYPE_MASK) ==
XEN_DOMCTL_PFINFO_L3TAB )
goto failed;
}
@@ -621,7 +621,7 @@ int xc_exchange_page(int xc_handle, int
old_ptes.cur = 0;
/* Unpin the page if it is pined */
- if (minfo.pfn_type[mfn] & XEN_DOMCTL_PFINFO_LPINTAB)
+ if (minfo.pfn_type[gpfn] & XEN_DOMCTL_PFINFO_LPINTAB)
{
mops.cmd = MMUEXT_UNPIN_TABLE;
mops.arg1.mfn = mfn;
Attachment:
xc_exchange.patch
Description: xc_exchange.patch
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [PATCH] Enhance memory exchange to support foreign domain -- Was RE: [Xen-devel] [PATCH 6/6] Change MMU_PT_UPDATE_RESERVE_AD to support update page table for foreign domain , Jiang, Yunhong |
|---|---|
| Next by Date: | Re: [Xen-devel] 2.6.30 dom0 Xen patches , Jan Beulich |
| Previous by Thread: | RE: [PATCH] Enhance memory exchange to support foreign domain -- Was RE: [Xen-devel] [PATCH 6/6] Change MMU_PT_UPDATE_RESERVE_AD to support update page table for foreign domain , Jiang, Yunhong |
| Next by Thread: | [Xen-devel] do_grant_table_op()'s input array size limitation , Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |