WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] xend: Sleep before sending SIGKILL to device mod

To: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: Sleep before sending SIGKILL to device model
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: 2009年1月28日 11:14:27 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: 2009年1月28日 03:14:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49801B68.5060700@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <49801B68.5060700@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] xend: Sleep before sending SIGKILL 
to device model"):
> When we destroy a domain, xend sends SIGTERM to the device model and
> wait by waitpid() until the device model process disappears.
> If we restarted xend during the lifetime of the domain, waitpid() fails
> because the device model is no longer a child of xend, and in that case
> xend gives up waiting for the shutdown of process and just send it
> SIGKILL immediately. This is problematic because most of the case the
> device model will be forcibly killed by xend before shutting itself
> down.
The code already has a timeout to forcibly kill the device model after
(I think) 10 seconds. Surely we should reuse that code path (and the
same timeout value) ?
Restarting xend is not a usual thing to do and I think it's OK if
shutting down a domain started by a previous xend involves waiting for
such a longer timeout. It's better to err on the side of safety.
Also, your patch was:
 Content-Type: all/allfiles;
This is not a recognised content type and prevented both of my
mailreaders from displaying it to me. Can you please fix your MUA ?
Alternatively, just include the patch in the body of the mail rather
than attaching it.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] [PATCH 0/3] Add date and domid to guest's console output. , Daniel P. Berrange
Next by Date: [Xen-devel] RE: [Xen-users] howto upgrade - APIC / Timer issue?? , Robert Dunkley
Previous by Thread: [Xen-devel] [PATCH] xend: Sleep before sending SIGKILL to device model , Yosuke Iwamatsu
Next by Thread: [Xen-devel] [PATCH] xend: Sleep before sending SIGKILL to device model , Yosuke Iwamatsu
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /