| To: | <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH] x86-64 don't generate dependency files when building compat headers |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | 2009年1月27日 11:20:50 +0000 |
| Delivery-date: | 2009年1月27日 03:20:45 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
The generated dependency files weren't correct (as their names get derived only from the base name of the target file, and there are public headers with the same base name in different directories), not needed (as the makefile already listed all necessary dependencies explicitly), and resulted in the first re-build in an already built tree to be an almost full re-build since the *.c files explicitly mentioned in the .*.d result in make not considering them as intermediate anymore, thus triggering re-generation of the headers, and hence re-building of almost the entire tree. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> --- 2009年01月27日.orig/xen/include/Makefile 2008年07月18日 16:19:34.000000000 +0200 +++ 2009年01月27日/xen/include/Makefile 2009年01月27日 10:42:37.000000000 +0100 @@ -51,7 +51,7 @@ compat/%.h: compat/%.i Makefile mv -f $@.new $@ compat/%.i: compat/%.c Makefile - $(CPP) $(CFLAGS) $(cppflags-y) -o $@ $< + $(CPP) $(filter-out -M% .$(@F).d,$(CFLAGS)) $(cppflags-y) -o $@ $< compat/%.c: public/%.h xlat.lst Makefile mkdir -p $(@D) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] x86: use alloc_domheap_page() consistently in dom0 building , Jan Beulich |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] x86: clean up struct page_info , Jan Beulich |
| Previous by Thread: | [Xen-devel] [PATCH] x86: use alloc_domheap_page() consistently in dom0 building , Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH] x86: clean up struct page_info , Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |