WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] revert: "netfront/back: do not mark packets of lengt

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] revert: "netfront/back: do not mark packets of length < MSS as GSO"
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: 2009年1月14日 13:51:58 +0100
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: 2009年1月14日 05:52:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1231938287 0
# Node ID 762b3109882589dfa69eb694a493a9273bcdf722
# Parent 107e10e0e07c3984630b8d3eaecb5bb957be387a
revert: "netfront/back: do not mark packets of length < MSS as GSO"
 changeset: 774:107e10e0e07c
 user: Keir Fraser <keir.fraser@xxxxxxxxxx>
 date: Tue Jan 13 15:17:54 2009 +0000
 summary: netfront/back: do not mark packets of length < MSS as GSO
Herbert Xu suggested a better fix in the network
stack which will follow.
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
diff -r 107e10e0e07c -r 762b31098825 drivers/xen/netback/netback.c
--- a/drivers/xen/netback/netback.c Tue Jan 13 15:17:54 2009 +0000
+++ b/drivers/xen/netback/netback.c Wed Jan 14 13:04:47 2009 +0000
@@ -1345,11 +1345,6 @@ static void net_tx_action(unsigned long 
 skb_shinfo(skb)->frags[0].page = (void *)~0UL;
 }
 
- if (skb->data_len < skb_shinfo(skb)->gso_size) {
- skb_shinfo(skb)->gso_size = 0;
- skb_shinfo(skb)->gso_type = 0;
- }
-
 __skb_queue_tail(&tx_queue, skb);
 
 pending_cons++;
diff -r 107e10e0e07c -r 762b31098825 drivers/xen/netfront/netfront.c
--- a/drivers/xen/netfront/netfront.c Tue Jan 13 15:17:54 2009 +0000
+++ b/drivers/xen/netfront/netfront.c Wed Jan 14 13:04:47 2009 +0000
@@ -1439,14 +1439,6 @@ err:
 np->stats.rx_packets++;
 np->stats.rx_bytes += skb->len;
 
-#if HAVE_TSO
- if (skb->data_len < skb_shinfo(skb)->gso_size) {
- skb_shinfo(skb)->gso_size = 0;
-#if HAVE_GSO
- skb_shinfo(skb)->gso_type = 0;
-#endif
- }
-#endif
 __skb_queue_tail(&rxq, skb);
 
 np->rx.rsp_cons = ++i;
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] revert: "netfront/back: do not mark packets of length < MSS as GSO", Ian Campbell <=
Previous by Date: [Xen-devel] [PATCH] xenpm: build fix , Christoph Egger
Next by Date: [Xen-devel] [PATCH] gso: Ensure that the packet is long enough , Ian Campbell
Previous by Thread: [Xen-devel] [PATCH] xenpm: build fix , Christoph Egger
Next by Thread: [Xen-devel] [PATCH] gso: Ensure that the packet is long enough , Ian Campbell
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /