WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] Re: [PATCH] Do not print `***' when compiling unless we fall

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] Do not print `***' when compiling unless we fall over
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2009 17:18:28 +0000
Delivery-date: 2009年1月09日 09:19:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18787.33193.687306.400216@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <18787.33193.687306.400216@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I wrote:
> This has finally bugged me enough to do something about it:
>
> make prints `***' when it stops due to an error. With make -j, and/or
> with automated build systems, this error marker can be in the middle
> of a large logfile. It is useful to be able to search for it.
>
> Therefore change occurrences of `*' to `#' for information and warning
> messages. `***' is reserved for cases where the build stops.
>
> A corresponding change is being applied to qemu-xen-unstable.
It turns out that the `make' on our automated testing systems is too
old to cope with $(warning ### something ###) even with quotes, so
here is a revised patch which uses === instead.
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Ian.
diff -r f2ede9e01d14 buildconfigs/mk.linux-2.6-common
--- a/buildconfigs/mk.linux-2.6-common Tue Jan 06 14:01:39 2009 +0000
+++ b/buildconfigs/mk.linux-2.6-common Tue Jan 06 15:52:03 2009 +0000
@@ -100,10 +100,10 @@ endif
 endif
 $(__NONINT_CONFIG) $(MAKE) -C $(LINUX_SRCDIR) ARCH=$(LINUX_ARCH) 
oldconfig O=$$(/bin/pwd)/$(LINUX_DIR)
 @set -e ; if [ ! -f $(LINUX_DIR)/Makefile ] ; then \
- echo "***********************************"; \
+ echo "==================================="; \
 echo "oldconfig did not create a Makefile"; \
 echo "Generating $(LINUX_DIR)/Makefile "; \
- echo "***********************************"; \
+ echo "==================================="; \
 ( echo "# Automatically generated: don't edit"; \
 echo ""; \
 echo "VERSION = 2"; \
diff -r f2ede9e01d14 docs/check_pkgs
--- a/docs/check_pkgs Tue Jan 06 14:01:39 2009 +0000
+++ b/docs/check_pkgs Tue Jan 06 15:57:53 2009 +0000
@@ -2,12 +2,12 @@ silent_which ()
 silent_which ()
 {
 which 1ドル 1>/dev/null 2>/dev/null || {
- echo "*************************************************"
- echo "*************************************************"
- echo "* WARNING: Package '1ドル' is required"
- echo "* to build Xen documentation"
- echo "*************************************************"
- echo "*************************************************"
+ echo "================================================="
+ echo "================================================="
+ echo "= WARNING: Package '1ドル' is required"
+ echo "= to build Xen documentation"
+ echo "================================================="
+ echo "================================================="
 }
 which 1ドル 1>/dev/null 2>/dev/null
 }
diff -r f2ede9e01d14 tools/blktap/drivers/Makefile
--- a/tools/blktap/drivers/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/blktap/drivers/Makefile Tue Jan 06 16:00:21 2009 +0000
@@ -22,7 +22,7 @@ CRYPT_LIB := -lgcrypt
 CRYPT_LIB := -lgcrypt
 else
 CRYPT_LIB := -lcrypto
-$(warning *** libgcrypt not installed: falling back to libcrypto ***)
+$(warning === libgcrypt not installed: falling back to libcrypto ===)
 endif
 
 LDFLAGS_blktapctrl := $(LDFLAGS_libxenctrl) $(LDFLAGS_libxenstore) -L../lib 
-lblktap
diff -r f2ede9e01d14 tools/firmware/Makefile
--- a/tools/firmware/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/firmware/Makefile Tue Jan 06 15:59:54 2009 +0000
@@ -15,10 +15,10 @@ SUBDIRS += hvmloader
 .PHONY: all
 all:
 @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut 
-d' ' -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $1,ドル $2,ドル $3ドル}'`)) -lt 
$$((0x00100e)) ] ; then \
- echo "***********************************************************"; \
+ echo "==========================================================="; \
 echo "Require dev86 package version >= 0.16.14 to build firmware!"; \
 echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
- echo "***********************************************************"; \
+ echo "==========================================================="; \
 else \
 $(MAKE) subdirs-$@; \
 fi
diff -r f2ede9e01d14 tools/vtpm/Makefile
--- a/tools/vtpm/Makefile Tue Jan 06 14:01:39 2009 +0000
+++ b/tools/vtpm/Makefile Tue Jan 06 15:59:45 2009 +0000
@@ -89,6 +89,6 @@ build_sub:
 $(MAKE) -C $(TPM_EMULATOR_DIR); \
 fi \
 else \
- echo "*** Unable to build VTPMs. libgmp could not be found."; \
+ echo "=== Unable to build VTPMs. libgmp could not be found."; \
 fi
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] [PATCH] stdvga improvements. , Trolle Selander
Next by Date: Re: [Xen-devel] pv_ops dom0 and kernel console output problem , Pasi Kärkkäinen
Previous by Thread: [Xen-devel] [PATCH] Do not print `***' when compiling unless we fall over , Ian Jackson
Next by Thread: Re: [Xen-devel] Re: pv_ops dom0 USB fixed , Gerd Hoffmann
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /