WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] ioemu-remote: check shutdown_requested timely.

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu-remote: check shutdown_requested timely.
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: 2008年12月30日 16:52:24 +0000
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: 2008年12月30日 08:53:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A4575045D4A00@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <EADF0A36011179459010BDF5142A4575045D4A00@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Cui, Dexuan writes ("[Xen-devel] [PATCH] ioemu-remote:
> After a recent merge of the ioemu-remote tree several weeks ago, I
> find in main() -> termsig_seup(), ioemu sets a SIGHUP handler that
> sets a global variable shutdown_requested to 1, but ioemu doesn't
> check the variable and as a result, ioemu wouldn't terminate when
> xend sends a SIGHUP to it; finally xend has to send a SIGKILL to it
> in 10 seconds. The small patch adds a check to terminate ioemu
> timely.
I can reproduce the problem you report here - the symptoms I see are
log messages in xend.log and that `xm destroy' is slow.
But while it's true that the main loop in vl.c doesn't check
qemu_shutdown_requested, that main loop is not compiled in in qemu-dm.
Did you test your fix ? Your fix would also seem to make qemu-dm exit
immediately if the domain powers off even if on_poweroff=preserve.
The root cause of the problem seems to be that upstream qemu installs
signal handlers for the common terminating signals, which simply
request shutdown. That's not appropriate for us because xend sends us
a signal when it wants us to really die. So I have disabled that and
the fix should be in the usual places soon.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] pv_ops dom0 kernel crashes , Pasi Kärkkäinen
Next by Date: Re: [Xen-devel] Windows SMP , Wei Huang
Previous by Thread: [Xen-devel] [PATCH] ioemu-remote: check shutdown_requested timely. , Cui, Dexuan
Next by Thread: RE: [Xen-devel] [PATCH] ioemu-remote: check shutdown_requested timely. , Cui, Dexuan
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /