WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] powernow: implement struct cpufreq_driver.verify

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] powernow: implement struct cpufreq_driver.verify
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: 2008年12月05日 14:22:07 +0000
Delivery-date: 2008年12月05日 06:21:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Without this, under rare conditions hypervisor crashes are possible due
to this method being called without checking against NULL.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
Index: 2008年11月20日/xen/arch/x86/acpi/cpufreq/powernow.c
===================================================================
--- 2008年11月20日.orig/xen/arch/x86/acpi/cpufreq/powernow.c 2008年11月05日 
16:54:22.000000000 +0100
+++ 2008年11月20日/xen/arch/x86/acpi/cpufreq/powernow.c 2008年12月03日 
11:56:27.000000000 +0100
@@ -129,6 +129,16 @@ static int powernow_cpufreq_target(struc
 return result;
 }
 
+static int powernow_cpufreq_verify(struct cpufreq_policy *policy)
+{
+ struct powernow_cpufreq_data *data;
+
+ if (!policy || !(data = drv_data[policy->cpu]))
+ return -EINVAL;
+
+ return cpufreq_frequency_table_verify(policy, data->freq_table);
+}
+
 static int powernow_cpufreq_cpu_init(struct cpufreq_policy *policy)
 {
 unsigned int i;
@@ -243,6 +253,7 @@ static int powernow_cpufreq_cpu_exit(str
 }
 
 static struct cpufreq_driver powernow_cpufreq_driver = {
+ .verify = powernow_cpufreq_verify,
 .target = powernow_cpufreq_target,
 .init = powernow_cpufreq_cpu_init,
 .exit = powernow_cpufreq_cpu_exit
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] powernow: implement struct cpufreq_driver.verify, Jan Beulich <=
Previous by Date: [Xen-devel] [PATCH] x86/32on64: adjust address when converting syscall to fault , Jan Beulich
Next by Date: [Xen-devel] [PATCH] x86/cpufreq: reduce verbosity , Jan Beulich
Previous by Thread: [Xen-devel] [PATCH] x86/32on64: adjust address when converting syscall to fault , Jan Beulich
Next by Thread: [Xen-devel] [PATCH] x86/cpufreq: reduce verbosity , Jan Beulich
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /