| To: | "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 1/4] x86: add FIX_HOLE |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | 2008年10月27日 12:21:42 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2008年10月27日 05:21:02 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C52B5F55.286F6%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4905B636.76E4.0078.0@xxxxxxxxxx> <C52B5F55.286F6%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 27.10.08 13:06 >>> >If no explanation can be given as to why this makes the highmem-assist patch >work, I can only reasonably take neither patch. Okay, okay, I recalled the problem after some staring at fixmap.h: The BUG_ON() in virt_to_fix() would trigger on FIX_PAE_HIGHMEM_0 without the hole, as fix_to_virt() on that index returns FIXADDR_TOP. >On 27/10/08 11:38, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > >> I have to admit that I don't recall the exact details of where I ran >> into a problem without this change, but it's a prerequisite for the >> highmem-assist patch. >> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH 1/4] x86: add FIX_HOLE , Keir Fraser |
|---|---|
| Next by Date: | RE: [Xen-devel] Problems with enabling hypervisor C and P-statecontrol , Tian, Kevin |
| Previous by Thread: | Re: [Xen-devel] [PATCH 1/4] x86: add FIX_HOLE , Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH 2/4] constify arguments to unmap_domain_page() & Co. , Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |