WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

RE: [Xen-devel] MSI causing softpanics in guest

To: "Haitao Shan" <haitao.shan@xxxxxxxxx>
Subject: RE: [Xen-devel] MSI causing softpanics in guest
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: 2008年9月24日 11:59:43 +0100
Cc: Anish Bhatt <anish@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: 2008年9月24日 03:59:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F6473715D25C9E46A5515027E5482F100887BDB2C6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F6473715D25C9E46A5515027E5482F100887BDB0F9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C4FF9708.1D821%keir.fraser@xxxxxxxxxxxxx> <F6473715D25C9E46A5515027E5482F100887BDB2C6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>--- a/drivers/pci/msi-xen.c Mon Sep 22 16:08:10 2008 +0100
>+++ b/drivers/pci/msi-xen.c Wed Sep 24 01:45:16 2008 +0800
>@@ -158,7 +158,11 @@ static int msi_unmap_pirq(struct pci_dev
> int rc;
>
> unmap.domid = msi_get_dev_owner(dev);
>- unmap.pirq = evtchn_get_xen_pirq(pirq);
>+ /* See comments in msi_map_pirq_to_vector, input parameter pirq
>+ * mean irq number only if the device belongs to dom0 itself.
>+ */
>+ if (unmap.domid == DOMID_SELF)
>+ unmap.pirq = evtchn_get_xen_pirq(pirq);
This seems to leave unmap.pirq uninitialized in the !DOMID_SELF case.
Otherwise, seems a reasonable alternative to doing it in pcifront/pciback.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: [Xen-devel] Re: dm-ioband + bio-cgroup benchmarks , Hirokazu Takahashi
Next by Date: Re: [Xen-devel] Re: [dm-devel] Re: dm-ioband + bio-cgroup benchmarks , Balbir Singh
Previous by Thread: Re: [Xen-devel] MSI causing softpanics in guest , Keir Fraser
Next by Thread: Re: [Xen-devel] MSI causing softpanics in guest , Anish Bhatt
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /