Hi, John
John Levon wrote:

This cset:
changeset: 11473:0008fca70351
date: Thu Sep 14 08:19:38 2006 +0100
description:
xm dump command add on
xm dump-core [-L|--live][-C| --crash] <domID> [output path]
Didn't actually implement anything. Worse, it looks like we don't even
pause the domain, so it's always live (not good). What's going on?

What do you mean? Why do you think "it looks like we don't even
pause the domain"? The following code of the patch looks like
we do pause domain by server.xend.domain.pause(dom).
+def xm_dump_core(args):
+ arg_check(args, "dump-core",1,3)
+ live = False
+ crash = False
+ import getopt
+ (options, params) = getopt.gnu_getopt(args, 'LC', ['live','crash'])
+
+ for (k, v) in options:
+ if k in ['-L', '--live']:
+ live = True
+ if k in ['-C', '--crash']:
+ crash = True
+
+ if len(params) == 0 or len(params) > 2:
+ err("invalid number of parameters")
+ usage("dump-core")
+
+ dom = params[0]
+ if len(params) == 2:
+ filename = os.path.abspath(params[1])
+ else:
+ filename = None
+
+ if not live:
+ server.xend.domain.pause(dom) <<< HERE
+
+ try:
+ print "dumping core of domain:%s ..." % str(dom)
+ server.xend.domain.dump(dom, filename, live, crash)
+ finally:
+ if not live:
+ server.xend.domain.unpause(dom)
+
+ if crash:
+ print "destroying domain:%s ..." % str(dom)
+ server.xend.domain.destroy(dom)
+
Best Regards,
Akio Takebe
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel