| To: | "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: adjust placement of pause insn in_raw_spin_lock() |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | 2008年8月08日 15:12:10 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2008年8月08日 07:11:52 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C4C204D9.2544D%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <489C5CE1.76E4.0078.0@xxxxxxxxxx> <C4C204D9.2544D%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
That's the way it's done elsewhere and it's recommended (i.e. pause immediately preceding the memory reference of the possibly contended location). Jan >>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 08.08.08 15:12 >>> Why? -- Keir On 8/8/08 13:49, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> > > Index: 2008年08月06日/xen/include/asm-x86/spinlock.h > =================================================================== > --- 2008年08月06日.orig/xen/include/asm-x86/spinlock.h 2007年09月10日 > 09:59:37.000000000 +0200 > +++ 2008年08月06日/xen/include/asm-x86/spinlock.h 2008年08月07日 12:36:13.000000000 > +0200 > @@ -23,8 +23,8 @@ static inline void _raw_spin_lock(spinlo > "1: lock; decb %0 \n" > " js 2f \n" > ".section .text.lock,\"ax\"\n" > - "2: cmpb 0,ドル%0 \n" > - " rep; nop \n" > + "2: rep; nop \n" > + " cmpb 0,ドル%0 \n" > " jle 2b \n" > " jmp 1b \n" > ".previous" > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] x86: adjust placement of pause insn in _raw_spin_lock() , Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] Re: RFC: I/O bandwidth controller , Hirokazu Takahashi |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86: adjust placement of pause insn in _raw_spin_lock() , Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH] x86: also show event upcall mask when dumping guest state , Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |