| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH] stubdom: fix read-only disks access |
| From: | Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
| Date: | Fri, 1 Aug 2008 19:17:50 +0100 |
| Delivery-date: | 2008年8月01日 11:18:13 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Mail-followup-to: | Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.12-2006年07月14日 |
stubdom: fix read-only disks access
There is no need for a flush on read-only disks. It would actually even
error out and disturb the guest.
Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
diff -r 3dedb6209991 tools/ioemu/block-vbd.c
--- a/tools/ioemu/block-vbd.c Fri Aug 01 12:18:02 2008 +0100
+++ b/tools/ioemu/block-vbd.c Fri Aug 01 19:16:52 2008 +0100
@@ -273,6 +273,10 @@ static BlockDriverAIOCB *vbd_aio_flush(B
BDRVVbdState *s = bs->opaque;
VbdAIOCB *acb = NULL;
+ if (s->info.mode == O_RDONLY) {
+ cb(opaque, 0);
+ return NULL;
+ }
if (s->info.barrier == 1) {
acb = vbd_aio_setup(bs, 0, NULL, 0,
s->info.flush == 1 ? vbd_nop_cb : cb, opaque);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Is exposing shared_info to user-land secure? , Keir Fraser |
|---|---|
| Next by Date: | Re: [PATCH] Re: [Xen-devel] distclean failure , Jeremy Fitzhardinge |
| Previous by Thread: | [Xen-devel] RE: [PATCH?] monotonically increasing Xen system time , Dan Magenheimer |
| Next by Thread: | Re: [Xen-devel] [PATCH] stubdom: fix read-only disks access , Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |