Alex Williamson wrote:

Hi Stefano,
On Thu, 2008年03月20日 at 18:14 +0000, Stefano Stabellini wrote:

Hi Alex,

I think I have found the bug that causes the strange behaviour you are describing, but I have no way to be sure because I cannot test it on a ia64 machine. Could you please try the patch I am attaching (to be applied on top of the other one)?

 Yes, this fixes it. Thanks!

great!
Sending the patch again more "officially" this time.
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

diff -r 491a3b62ae5b tools/ioemu/vnc.c
--- a/tools/ioemu/vnc.c Thu Mar 20 17:48:02 2008 +0000
+++ b/tools/ioemu/vnc.c Thu Mar 20 18:03:52 2008 +0000
@@ -370,16 +370,20 @@ static void vnc_dpy_resize(DisplayState 
 int o;
 
 if (!ds->shared_buf) {
+ ds->linesize = w * vs->depth;
 if (allocated)
- ds->data = realloc(ds->data, h * linesize);
+ ds->data = realloc(ds->data, h * ds->linesize);
 else
- ds->data = malloc(h * linesize);
+ ds->data = malloc(h * ds->linesize);
 allocated = 1;
- } else if (allocated) {
- free(ds->data);
- allocated = 0;
- }
- vs->old_data = realloc(vs->old_data, h * linesize);
+ } else {
+ ds->linesize = linesize;
+ if (allocated) {
+ free(ds->data);
+ allocated = 0;
+ }
+ }
+ vs->old_data = realloc(vs->old_data, h * ds->linesize);
 vs->dirty_row = realloc(vs->dirty_row, h * sizeof(vs->dirty_row[0]));
 vs->update_row = realloc(vs->update_row, h * sizeof(vs->dirty_row[0]));
 
@@ -396,7 +400,6 @@ static void vnc_dpy_resize(DisplayState 
 size_changed = ds->width != w || ds->height != h;
 ds->width = w;
 ds->height = h;
- ds->linesize = linesize;
 if (vs->csock != -1 && vs->has_resize && size_changed) {
 vs->width = ds->width;
 vs->height = ds->height;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel