WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] linux/x86: simplify synch_test_bit()

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] linux/x86: simplify synch_test_bit()
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: 2008年3月14日 07:54:00 +0000
Delivery-date: 2008年3月14日 00:53:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
There really is no need for a redundant implementation here, just keep
the alternative name for allowing consumers to use consistent naming.
As usual, written and tested on 2.6.25-rc5 and made apply to the 2.6.18
tree without further testing.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
Index: head-2008年03月11日/include/asm-i386/mach-xen/asm/synch_bitops.h
===================================================================
--- head-2008年03月11日.orig/include/asm-i386/mach-xen/asm/synch_bitops.h 
2008年03月12日 17:07:19.000000000 +0100
+++ head-2008年03月11日/include/asm-i386/mach-xen/asm/synch_bitops.h 
2008年03月12日 17:10:21.000000000 +0100
@@ -119,26 +119,7 @@ static inline unsigned long __synch_cmpx
 return old;
 }
 
-static __always_inline int synch_const_test_bit(int nr,
- const volatile void * addr)
-{
- return ((1UL << (nr & 31)) & 
- (((const volatile unsigned int *) addr)[nr >> 5])) != 0;
-}
-
-static __inline__ int synch_var_test_bit(int nr, volatile void * addr)
-{
- int oldbit;
- __asm__ __volatile__ (
- "btl %2,%1\n\tsbbl %0,%0"
- : "=r" (oldbit) : "m" (ADDR), "Ir" (nr) );
- return oldbit;
-}
-
-#define synch_test_bit(nr,addr) \
-(__builtin_constant_p(nr) ? \
- synch_const_test_bit((nr),(addr)) : \
- synch_var_test_bit((nr),(addr)))
+#define synch_test_bit test_bit
 
 #define synch_cmpxchg_subword synch_cmpxchg
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] linux/x86: simplify synch_test_bit(), Jan Beulich <=
Previous by Date: [Xen-devel] RE: the /gplpv option , James Harper
Next by Date: Re: [Xen-devel] Release 0.8.5 of GPL PV drivers for Windows , Pasi Kärkkäinen
Previous by Thread: [Xen-devel] RE: the /gplpv option , James Harper
Next by Thread: [Xen-ia64-devel] [IA64] Weekly benchmark results [ww10] , KUWAMURA Shin'ya
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /