This changeset added pcifront_{at,de}tach_devices() to
drivers/xen/pcifront/xenbus.c, the two functions, however, return
inconsistent/bogus return values, but their only caller doesn't care:
Depending on the compiler version, the case of
pcifront_detach_devices() leaving 'err' uninitialized may get warned
about, and pcifront_attach_devices() would return -EFAULT if called
in the wrong state.
However, given the return values aren't used I'm really uncertain
whether to just make the functions return 'void' or whether to fix the
error values. Please advise.
Thanks, Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel