>+ short temp = 0xff;
Please use 0xffffffff here for forward compatibility.
>+
>+ if ( !opt_dom0_vcpus_pin)
>+ rc = -EINVAL;
>+ rc = -EFAULT;
This makes no sense; it's probably missing a 'break'.
>+
>+ cpu_id.phys_id = x86_cpu_to_apicid[cpu_num];
>+ for (i = 0; i++; i < NR_CPUS) 
>+ if (x86_acpiid_to_apicid[i] == x86_cpu_to_apicid[cpu_num])
>+ temp = i;
>+ cpu_id.phys_id |= temp << 8;
Please shift by 32 here for forward compatibility.
>-static unsigned int opt_dom0_vcpus_pin;
>+unsigned int opt_dom0_vcpus_pin;
>+EXPORT_SYMBOL(opt_dom0_vcpus_pin);
EXPORT_SYMBOL()?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel