| To: | "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] question on c/s 15964 |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | 2007年9月27日 08:02:01 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2007年9月27日 00:01:32 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Keir, in the new function reserve_e820_ram() you do nothing *and* return 0 (success) if an entry would need to be split but there's no room. This seems dangerous to me; in the original version of the patch I had sent I truncated the entry instead, choosing the variant (start or end) that resulted in less loss of memory. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH][RFC] making "xm dump-core" paralell , John Levon |
|---|---|
| Next by Date: | [Xen-devel] Reporting a traceback , Marc Patino Gómez |
| Previous by Thread: | [Xen-devel] [PATCH][RFC] making "xm dump-core" paralell , Rikiya Ayukawa |
| Next by Thread: | [Xen-devel] Re: question on c/s 15964 , Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |