| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Joseph Cihula <joseph.cihula@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Prevent incorrect optimization of read_crx() |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | 2007年9月11日 08:12:01 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2007年9月11日 00:08:04 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <46E65733.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acf0QwxRSrw4BWA2EdylYQAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH] Prevent incorrect optimization of read_crx() |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 11/9/07 07:52, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > Wouldn't you need to put __volatile__ in write_crX(), too? Actually it is surprising that the compiler hasn't been optimising away our write_cr0() entirely. Perhaps it special cases asm blocks with no outputs. Adding the volatile keyword makes a lot of sense anyway. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Prevent incorrect optimization of read_crx() , Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] xs transaction , Tian, Kevin |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Prevent incorrect optimization of read_crx() , Keir Fraser |
| Next by Thread: | [Xen-devel] xs transaction , Tian, Kevin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |