| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] PATCH: Avoid struct members clashing with POSIX apis |
| From: | "Daniel P. Berrange" <berrange@xxxxxxxxxx> |
| Date: | 2007年8月22日 22:46:53 +0100 |
| Delivery-date: | 2007年8月22日 14:47:30 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Reply-to: | "Daniel P. Berrange" <berrange@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
The TPM code in tools/ioemu/hw/tpm_tis.c has a struct containing a number of function pointers with names open, close, read, write which are the same as various POSIX apis already #included in the file. POSIX allows these functions to be defined as macros and latest GCC/glibc does indeed define them as macros depending on compiler flags. This causes compile errors when deferencing the struct members. The solution is either to change calls like ctx->open () to be (* ctx->open) (), or simply to rename the struct members. Since this struct was only used inside that one file i simply renamed them. Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Attachment:
xen-tpm-functions.patch
Description: Text document
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel][Xense-devel][PATCH][4/4] Xen Security Modules - ACM Module , George S. Coker, II |
|---|---|
| Next by Date: | [Xen-devel] PATCH: 0/10: Merge paravirt FB & console into qemu-dm , Daniel P. Berrange |
| Previous by Thread: | [Xen-devel] HVM Live Migration: Failed to populate physmap , sanjay kushwaha |
| Next by Thread: | [Xen-devel] PATCH: 0/10: Merge paravirt FB & console into qemu-dm , Daniel P. Berrange |
| Indexes: | [Date] [Thread] [Top] [All Lists] |