| To: | PUCCETTI Armand <armand.puccetti@xxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] mini-os: C programming |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | 2007年3月15日 13:54:06 +0000 |
| Delivery-date: | 2007年3月15日 06:53:20 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <45F94C89.4010603@xxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcdnCWWVo/z1+NL8Edu/SQAX8io7RQ== |
| Thread-topic: | [Xen-devel] mini-os: C programming |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 15/3/07 13:39, "PUCCETTI Armand" <armand.puccetti@xxxxxx> wrote: > extern char *stack; Yes, this one is bogus. > 2. In file xen-3.0.3/extras/mini-os/gnttab.c:140: the const variable > gnttabop_error_msgs > is declared as > > static const char *gnttabop_error_msgs[] = GNTTABOP_error_msgs; > > shouldn't that instead be declared: > > static const char * const gnttabop_error_msgs[] = GNTTABOP_error_msgs; It doesn't really matter, does it? Personally I hate scattering 'const' all over the place. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] mini-os: C programming , PUCCETTI Armand |
|---|---|
| Next by Date: | Re: [Xen-devel] performance counters , Jan Beulich |
| Previous by Thread: | [Xen-devel] mini-os: C programming , PUCCETTI Armand |
| Next by Thread: | Re: [Xen-devel] mini-os: C programming , PUCCETTI Armand |
| Indexes: | [Date] [Thread] [Top] [All Lists] |