| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h |
| From: | "Christoph Egger" <Christoph.Egger@xxxxxxx> |
| Date: | 2007年1月12日 14:43:32 +0100 |
| Cc: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Delivery-date: | 2007年1月12日 06:04:05 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C1CD3F8A.789C%keir@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Organization: | AMD / OSRC |
| References: | <C1CD3F8A.789C%keir@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | KMail/1.9.4 |
On Friday 12 January 2007 14:37, Keir Fraser wrote:
> On 12/1/07 12:01, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:
> >> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
> >> argument as the first argument. So I remove the consts from
> >> the initializer.
> >> I replace typeof with __typeof__, which is always available
> >> in gcc - it is
> >> not, when the -ansi option is used.
> >
> > And is it expected that Xen will EVER be compiled with -ansi? I think
> > there's enough gcc-isms in other places that this will never happen -
> > not that it really makes any difference, I'm just curious if anyone
> > "cares"...
>
> Yes, I'm going to take the const cleanups but bin the __typeof__ changes.
Do you also take the small bugfix in the __copy_field_from_guest() function
at the very bottom in my patch ?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h , Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h , Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h , Keir Fraser |
| Next by Thread: | Re: [Xen-devel] [PATCH] Cleanup asm-x86/guest_access.h , Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |