WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: 2007年1月11日 16:17:51 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: 2007年1月11日 08:15:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1CC0C8D.77B4%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45A668F1.76E4.0078.0@xxxxxxxxxx> <C1CC0C8D.77B4%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Jan 11, 2007 at 03:47:25PM +0000, Keir Fraser wrote:
> > Properly conditionalize two places where compat-only structure fields get
> > accessed, and avoid compiler warnings on unused variables in two other
> > places.
>
> Should we bother to #ifdef where we don't need to? It's ugly and the
> compiler should be able to remove dead code where a condition evaluates to
> zero at compile time: we already have IS_COMPAT(d) hardcoded to zero if
> !CONFIG_COMPAT, which is enough to give the compiler a fair chance.
>
> -- Keir
The problem is the COMPAT_ARG_XLAT_VIRT_BASE used in that chunk.
regards
john
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] [PATCH 0/8] HVM save restore , Zhai, Edwin
Next by Date: Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability , John Levon
Previous by Thread: Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled , Keir Fraser
Next by Thread: Re: [Xen-devel] [PATCH] fix build when CONFIG_COMPAT disabled , Jan Beulich
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /