| To: | John Levon <levon@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | 2007年1月10日 18:21:05 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2007年1月10日 10:20:44 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070110173719.GA31121@xxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acc05Bc2Va8U+qDXEduNDgAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] Partial fix for compat build non-portability |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 10/1/07 17:37, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote: > Still to be resolved is the pragma pack push issue; this is non-portable > pragma only enabled on some targets, as it's intended for win32 > compatibility not something for general use. We should be wrapping each > structure in a pragma pack(4) / pragma pack() pair, but trying to fix > that makes my head hurt, and Jan isn't interested. We only care about it working for the x86/64 target since that's the only one that asserts CONFIG_COMPAT. Why would wrapping structs individually be better than wrapping whole header files? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability , Emmanuel Ackaouy |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability , Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability , Emmanuel Ackaouy |
| Next by Thread: | Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability , John Levon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |