WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] fix free of event channel in blkfront

To: "Steven Hand" <Steven.Hand@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix free of event channel in blkfront
From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
Date: Tue, 9 Jan 2007 19:48:42 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: 2007年1月09日 02:49:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1H0LwV-0005UQ-00@xxxxxxxxxxxxxxxxx><023701c73385$dbfd0e50$dab2220a@VF03007L > <071e01c733b60845ドルe010$dab2220a@VF03007L >
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Steven,
We tested the xm block-attach/detach command.
It repeats block-attach/detach command for DomU and pv-on-hvm on HVM Domain.
(block-attach -> block-detach -> block-attach -> block-detach -> ...)
The block-attach command failed when repeating 256 times.
I can't reproduce this - just tested 500 or so attach/detach pairs in
a tight loop and worked for me. However I was using a regular domU -
is it pv-on-hvm only? Can you give a more detailed repro case (or a
script)?
It already seems to have been corrected.
・xen-unstable.hg : cs 13198
 [PV-ON-HVM] Update evtchn interface to match new PV Linux interfaces.
----------------------------------------------------------------------------------------------------
--- a/unmodified_drivers/linux-2.6/platform-pci/evtchn.c Sat Dec 30 18:23:27 2006 +0000 +++ b/unmodified_drivers/linux-2.6/platform-pci/evtchn.c Sun Dec 31 11:59:47 2006 +0000
@@ -118,8 +144,12 @@ void unbind_from_irqhandler(unsigned int
 mask_evtchn(evtchn);
 evtchns[evtchn].handler = NULL;
+
+ if (evtchns[evtchn].close) {
+ struct evtchn_close close = { .port = evtchn };
+ HYPERVISOR_event_channel_op(EVTCHNOP_close, &close);
+ }
}
-
EXPORT_SYMBOL(unbind_from_irqhandler);
void notify_remote_via_irq(int irq)
----------------------------------------------------------------------------------------------------
However, the following problems remain.
I think that it operates if the following problems can be solved.
It is necessary to correct pv-on-hvm according to the following corrections.
・xen-unstable.hg : cs 13197
 [LINUX] Extend the event-channel interfaces to provide helper methods
I confirmed it with up-to-date xen-unstable.hg. (cs 13282)
It did not reproduce it in DomU.
Because VBD was not able to be used, pv-on-hvm was not able to confirm it.
The following errors occur.
# insmod xen-vbd.ko
xen-vbd: Unknown symbol irq_to_evtchn_port
insmod: error inserting 'xen-vbd.ko': -1 Unknown symbol in module
Thanks,
--
Takanori Kasai
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] Slow Disk io , Sébastien RICCIO
Next by Date: Re: [Xen-devel] using PageForeign for pte allocation vs. shortcutting __pte_free_tlb() , Gerd Hoffmann
Previous by Thread: Re: [Xen-devel] [PATCH] fix free of event channel in blkfront , Kasai Takanori
Next by Thread: Re: [Xen-devel] [PATCH] fix free of event channel in blkfront , tgh
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /