WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:

To: Brendan Cully <brendan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a
From: Alastair Tse <atse@xxxxxxxxxxxxx>
Date: 2006年12月07日 14:45:01 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: 2006年12月07日 06:45:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061206024345.GC13614@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <013e995e2a6b0c5b237b.1165276770@xxxxxxxxxxxxxxxxx> <20061205205118.GA13614@xxxxxxxxxxxxxxxxx> <20061205232147.GB10736@xxxxxxxxxxxxxxxxxxxxxx> <20061206002234.GB13614@xxxxxxxxxxxxxxxxx> <20061206024345.GC13614@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2006年12月05日 at 18:43 -0800, Brendan Cully wrote:
> > > > vif = ['ip=xxx.xxx.xxx.xxx'] hasn't worked since 12633 (at least with
> > > > Xen's nat scripts). The problem is that pre-12633, the IP field
> > > > returned from the config parser was a list, but now it is a string. So
> > > > ' '.join(ip) ends up sending 'x x x . x x x . x x x . x x x' to the
> > > > scripts, which were expecting less whitespace.
> > > 
> > > So does your fix mean that multiple IP addresses work again, or can we
> > > only have one address this way? I'd prefer to fix the config parser if
> > > that's what's needed to support multiple IP addresses, since it
> > > certainly used to work.
I cleaned up the device SXP parsing in XendConfig which has the side
effect of fixing this IP address parsing problem in vif. The problem was
the SXP parsing went through two different paths depending on which
point the device configuration was inserted. This is in cs 12786.
The multiple IP address should still continue to work as before.
Cheers,
Alastair
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: RE: [Xen-devel] [RFC][PATCH] 1/3] [XEN] Use explicit bit sized fieldsfor exported xentrace data. , Ian Pratt
Next by Date: Re: [Xen-devel] [PATCH][XEND] resume broken , Chris
Previous by Thread: Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a , Brendan Cully
Next by Thread: [Xen-devel] [PATCH] Add error reporting to libxc library , Daniel P. Berrange
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /