| To: | xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [PATCH][RESEND] Fix HV to properly copy runstate info |
| From: | Glauber de Oliveira Costa <gcosta@xxxxxxxxxx> |
| Date: | 2006年10月23日 16:29:15 -0300 |
| Delivery-date: | 2006年10月23日 12:19:48 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.11 |
Keir, I guess this patch does the right thing regarding the copy of the runstate_memory_area without breaking the ABI. Thanks, -- Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom"
--- xen-unstable/xen/arch/x86/domain.c.old 2006年10月04日 01:39:48.000000000
-0300
+++ xen-unstable/xen/arch/x86/domain.c 2006年10月20日 15:08:46.000000000 -0300
@@ -376,6 +376,7 @@ arch_do_vcpu_op(
case VCPUOP_register_runstate_memory_area:
{
struct vcpu_register_runstate_memory_area area;
+ struct vcpu_runstate_info runstate;
rc = -EFAULT;
if ( copy_from_guest(&area, arg, 1) )
@@ -387,9 +388,9 @@ arch_do_vcpu_op(
rc = 0;
v->runstate_guest = area.addr.v;
- if ( v == current )
- __copy_to_user(v->runstate_guest, &v->runstate,
- sizeof(v->runstate));
+ vcpu_runstate_get(v,&runstate);
+ __copy_to_user(v->runstate_guest, &runstate,
+ sizeof(runstate));
break;
}
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: Error reporting capabilities for libxc , Anthony Liguori |
|---|---|
| Next by Date: | [Xen-devel] [PATCH][RESEND] Raise DevError for device not found at blkif.py , Glauber de Oliveira Costa |
| Previous by Thread: | [Xen-devel] [PATCH 5/6] xen, tools: add nr_cpus field to fix nr_cpus calc , Ryan Harper |
| Next by Thread: | Re: [Xen-devel] [PATCH][RESEND] Fix HV to properly copy runstate info , Glauber de Oliveira Costa |
| Indexes: | [Date] [Thread] [Top] [All Lists] |